Android render #30

CedricGuillemet · 2019-08-19T21:04:48Z

New features

Android Native activity. Basically looks like a Win32 project (messages, main,..). This second Android project shows how to use libnative without the Java activity and content view. Depending on the needs, user might chose one or the other as a startup example
width/height parameters for the runtime init. Suggest to change. I added the parameters because I needed them for the activity init.
bgfx callback : bgfx trace messages are now routed to the console. testapp has to set the correct output depending on the platform . Outputting done for Android and Win32
debug output of backend rendering api
screen rotation support
shader preprocessor: shaders work out of the box on d3d11, opengl, opengles
library/bgfx/… build is handled by Android studio. No more the need to generate ninja build files

Issues

~~- face winding seem inverted with opengl. I didn't find any flag in bgfx that declares it. Not a bug issue for now~~
~~- Vertex Attribute names: I had to change it manually because by default they are not remapped (and apparently no remapping functions in glslang)~~
- Uniform struct: for VS and FS, uniforms are part of a structure called 'Frame'. There is a size conflict (and content) during linking. I'll try to make it work by renaming both structure (FrameVS and FrameFS) but another solution is needed
- uniform types: bgfx only allow vec4/mat4 uniforms. Any other type results in a runtime error and no update of the uniforms. I can't think of another solution of using an AST and parsing the shader source. Any idea?
~~- Shaders are not used the same depending on Android and Windows Opengl. For Windows, I made it work by adding #version 430. Not a stopping issue.~~

Android event management/life cycle/app switching,... Main concern is the context switching. When switching to another app, the window (and its context) are destroyed. At least with the Java activity. I'll check with the native activity to see if it behaves the same. --> will be fixed in another PR

Android Java activity project update

syntheticmagus · 2019-08-22T23:06:06Z

Looks like Git has confused itself somehow about Win32/App.cpp. Can we revert whatever it thinks it did to that file?

Library/CMakeLists.txt

syntheticmagus · 2019-08-22T23:20:09Z

Library/Include/Babylon/RuntimeAndroid.h

@@ -10,7 +10,8 @@ namespace babylon
    {
    public:
        explicit RuntimeAndroid(ANativeWindow* nativeWindowPtr);
-        explicit RuntimeAndroid(ANativeWindow* nativeWindowPtr, const std::string& rootUrl);
+        explicit RuntimeAndroid(ANativeWindow* nativeWindowPtr, const std::string& rootUrl, uint32_t width, uint32_t height);


@bghgary API change. I think I like this better than what we were doing before, which (I think) was to call UpdateSize() immediately from outside. Is there a case where you want to create a renderer, but don't know the size yet? If so, could we just add some defaults here?

What is the purpose of this change? Is there not a way to get the width and height of the native window on Android?

Library/Source/Console.h

Library/Source/NativeEngine.cpp

Library/Source/ShaderCompilerOpenGL.cpp

Library/Source/NativeEngine.cpp

Library/Source/ShaderCompilerOpenGL.cpp

TestApp/Source/Android/app/CMakeLists.txt

…nto AndroidRender # Conflicts: # Library/CMakeLists.txt # TestApp/Source/Win32/App.cpp

Library/CMakeLists.txt

bghgary · 2019-09-16T15:57:16Z

Library/Dependencies/napi/CMakeLists.txt

@@ -74,7 +74,7 @@ target_include_directories(napi PUBLIC "include")

 if(NAPI_JAVASCRIPT_ENGINE STREQUAL "Chakra")
    target_link_libraries(napi PRIVATE "chakrart.lib")
-elseif(NAPI_JAVASCRIPT_ENGINE STREQUAL "V8")
+elseif(NAPI_JAVASCRIPT_ENGINE STREQUAL "V8" AND NOT ANDROID)
    target_link_libraries(napi PRIVATE v8)


maybe we should rename the v8 target to v8windows or something

bghgary · 2019-09-16T15:59:08Z

Library/Include/Babylon/RuntimeAndroid.h

@@ -10,7 +10,8 @@ namespace babylon
    {
    public:
        explicit RuntimeAndroid(ANativeWindow* nativeWindowPtr);
-        explicit RuntimeAndroid(ANativeWindow* nativeWindowPtr, const std::string& rootUrl);
+        explicit RuntimeAndroid(ANativeWindow* nativeWindowPtr, const std::string& rootUrl, uint32_t width, uint32_t height);


What is the purpose of this change? Is there not a way to get the width and height of the native window on Android?

bghgary · 2019-09-16T16:02:16Z

Library/Source/NativeEngine.cpp

@@ -377,19 +377,25 @@ namespace babylon

        bx::DefaultAllocator m_allocator;
        uint64_t m_engineState;
-
+        void *m_nativeWindow{};


Suggested change

void *m_nativeWindow{};

void* m_nativeWindow{};

…nto AndroidRender # Conflicts: # Library/CMakeLists.txt # Library/Source/NativeEngine.cpp # TestApp/Scripts/babylon.max.js

…nto AndroidRender # Conflicts: # Library/CMakeLists.txt

…nNative into AndroidRender # Conflicts: # Library/Dependencies/bgfx.cmake # Library/Source/RuntimeAndroid.cpp # TestApp/Source/Android/app/CMakeLists.txt # TestApp/Source/Android/app/build.gradle

…nto AndroidRender # Conflicts: # TestApp/Scripts/babylon.max.js

…/BabylonNative into AndroidRender # Conflicts: # TestApp/Source/Android/app/build.gradle # TestApp/Source/Android/gradle/wrapper/gradle-wrapper.properties

…nto AndroidRender

bjs update

…nto AndroidRender

…et/BabylonNative into AndroidRender # Conflicts: # Library/Source/RuntimeAndroid.cpp # TestApp/Source/Android/app/src/main/cpp/BabylonNativeJNI.cpp

…abylonNative into AndroidRender # Conflicts: # TestApp/Source/Android/.idea/codeStyles/Project.xml # TestApp/Source/Android/app/build.gradle # TestApp/Source/Android/gradle/wrapper/gradle-wrapper.properties

…nto AndroidRender

CedricGuillemet · 2019-12-18T08:59:01Z

Closing PR as it's not meant to be merged in master.

CedricGuillemet added 2 commits August 16, 2019 15:10

WIP

156eb02

Android Native Activity

0fdd0e1

Android Java activity project update

CedricGuillemet requested review from bghgary and syntheticmagus August 19, 2019 21:04

CedricGuillemet added 2 commits August 19, 2019 14:07

remove cache files

cd8312d

Android screen rotation support

1219c89

CedricGuillemet added the draft label Aug 20, 2019

CedricGuillemet added 4 commits August 20, 2019 13:09

comment moved, output log removed

d87ceb2

preprocessing shaders for opengl(es)

c0087af

Attribute name remapping for BJS

708ced4

A bit of cleaning

3180a89

CedricGuillemet removed the draft label Aug 22, 2019

let bgfx decide the right api to use

ec17839

syntheticmagus suggested changes Aug 23, 2019

View reviewed changes

CedricGuillemet added 5 commits August 23, 2019 14:16

update js

61dd901

no need to use ninja anymore

3ba863d

cmake for Android java activity

0933061

feedback addressed

a981fc0

bgfx trace

05a23a9

syntheticmagus mentioned this pull request Aug 27, 2019

Make Console not be static again #37

Closed

CedricGuillemet added 3 commits August 27, 2019 09:05

Merge branch 'master' of https://github.com/BabylonJS/BabylonNative i…

99fa90c

…nto AndroidRender # Conflicts: # Library/CMakeLists.txt # TestApp/Source/Win32/App.cpp

vulkan shader compiler

dd955d0

removed bgfxcallback

1e83138

bghgary reviewed Sep 16, 2019

View reviewed changes

CedricGuillemet added 5 commits September 30, 2019 14:47

default window size at init

f220d14

Merge branch 'master' of https://github.com/BabylonJS/BabylonNative i…

85f5954

…nto AndroidRender # Conflicts: # Library/CMakeLists.txt # Library/Source/NativeEngine.cpp # TestApp/Scripts/babylon.max.js

Merge branch 'master' of https://github.com/BabylonJS/BabylonNative i…

b9c41cb

…nto AndroidRender # Conflicts: # Library/CMakeLists.txt

Merge branch 'AndroidCI' of https://github.com/CedricGuillemet/Babylo…

0e8f9f3

…nNative into AndroidRender # Conflicts: # Library/Dependencies/bgfx.cmake # Library/Source/RuntimeAndroid.cpp # TestApp/Source/Android/app/CMakeLists.txt # TestApp/Source/Android/app/build.gradle

androidNativeActivity pipeline

7c9837b

CedricGuillemet added 7 commits November 4, 2019 17:56

Android Asset loader callback

0d0bd91

fix gradle build

acfb6cf

namespace global for loader function

3361d45

Merge branch 'master' of https://github.com/BabylonJS/BabylonNative i…

4272e14

…nto AndroidRender # Conflicts: # TestApp/Scripts/babylon.max.js

Merge branch 'resourceLoaderCB' of https://github.com/CedricGuillemet…

be5f949

…/BabylonNative into AndroidRender # Conflicts: # TestApp/Source/Android/app/build.gradle # TestApp/Source/Android/gradle/wrapper/gradle-wrapper.properties

modules xml

a4008cd

resource loading using root path

fe10d5d

CedricGuillemet mentioned this pull request Nov 15, 2019

resourceLoadingCallback for Android APK resources #88

Closed

CedricGuillemet added 18 commits November 15, 2019 09:46

Merge branch 'master' of https://github.com/BabylonJS/BabylonNative i…

8dfd3fa

…nto AndroidRender

assetmgr for nativeActivity

d6924d3

bjs update

update shader compiler opengl

3a34c90

readme infos for Android

062d00f

Merge branch 'master' of https://github.com/BabylonJS/BabylonNative i…

d55bd63

…nto AndroidRender

find the issue with the bacl square in the middle of the screen

77ec680

WIP opengl shader loading

00f992a

Merge branch 'vertexLayoutUpdate' of https://github.com/CedricGuillem…

4cacf6c

…et/BabylonNative into AndroidRender # Conflicts: # Library/Source/RuntimeAndroid.cpp # TestApp/Source/Android/app/src/main/cpp/BabylonNativeJNI.cpp

Babylon namespace

ee41eb5

UVs work

337ea82

removed dead code

34a4b35

Merge branch 'openSSLAndroid' of https://github.com/CedricGuillemet/B…

09a79a5

…abylonNative into AndroidRender # Conflicts: # TestApp/Source/Android/.idea/codeStyles/Project.xml # TestApp/Source/Android/app/build.gradle # TestApp/Source/Android/gradle/wrapper/gradle-wrapper.properties

Merge branch 'master' of https://github.com/BabylonJS/BabylonNative i…

9a554cb

…nto AndroidRender

Merge branch 'master' of https://github.com/BabylonJS/BabylonNative i…

8c37ebd

…nto AndroidRender

disable peer/host checks. BabylonJS#96

1571743

update viewport size when screen is rotated

f340e2f

suspend/resume + proper surface changed handling

f5eee4e

babylonjs max update

fdf1f36

CedricGuillemet closed this Dec 18, 2019

Alex-MSFT mentioned this pull request May 29, 2020

BGFX Crash when loading CesiumMan example model #280

Closed

CedricGuillemet mentioned this pull request Oct 22, 2020

Render threading #451

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android render #30

Android render #30

CedricGuillemet commented Aug 19, 2019 •

edited

syntheticmagus commented Aug 22, 2019

syntheticmagus Aug 22, 2019

bghgary Sep 16, 2019

bghgary Sep 16, 2019

bghgary Sep 16, 2019

bghgary Sep 16, 2019

CedricGuillemet commented Dec 18, 2019

Android render #30

Android render #30

Conversation

CedricGuillemet commented Aug 19, 2019 • edited

New features

Issues

syntheticmagus commented Aug 22, 2019

syntheticmagus Aug 22, 2019

Choose a reason for hiding this comment

bghgary Sep 16, 2019

Choose a reason for hiding this comment

bghgary Sep 16, 2019

Choose a reason for hiding this comment

bghgary Sep 16, 2019

Choose a reason for hiding this comment

bghgary Sep 16, 2019

Choose a reason for hiding this comment

CedricGuillemet commented Dec 18, 2019

CedricGuillemet commented Aug 19, 2019 •

edited