Enable hit testing against different entityTypes in BabylonNative #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bghgary
approved these changes
Aug 12, 2020
There was a problem hiding this comment.
Seems okay to me. @syntheticmagus Do you want to review it also?
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
…BabylonNative into hitTestTrackableTypes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the BabylonNative half of Babylon.js change #8724, which resolves #356. This change enables hit testing against the three different supported entity types for WebXR: "plane", "mesh", and "point".
This just hooks up the API to the native hit test code for filtering our hit test queries. The way I have represented the enum internally is as a bitfield enum to allow specifying multiple hit test target types.