Cubemap rendering #816
Closed
Cubemap rendering #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are build failures. @syntheticmagus How does this change jive with your changes? |
|
@bghgary @syntheticmagus the shader manipulation part might be removed this week but the framebuffer will stay. Seting PR as draft until I get new BJS with shader flips by Alexis. |
|
@CedricGuillemet this fixes #398 right? |
|
@ryantrem yes |
|
Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For use with pointlight shadows.
Also fixes invertY for RTT and cubemap loading.
FrameBuffercan refer to a 2D Framebuffer or it can holds 6 framebuffers for cubemap. A boolean properym_cubeFrameBufferis used to determine its nature.This PR will be updated once BabylonJS/Babylon.js#10581 is in a new NPM.