Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BN #645

Merged
merged 7 commits into from
May 24, 2024
Merged

Update BN #645

merged 7 commits into from
May 24, 2024

Conversation

CedricGuillemet
Copy link
Contributor

@CedricGuillemet CedricGuillemet commented May 20, 2024 •
edited
Loading

fixes #644

Tested OK on Android except rendering (see BabylonJS/BabylonNative#1382 )

  • Replaced Node 12 with 18 for publishing (why 12 before?).
  • Xcode 15 instead of 13
  • Fixed library path in vcxproj
  • up BN to BabylonJS/BabylonNative@59798a7 and bjs version must be >= 5.53.1

@CedricGuillemet CedricGuillemet marked this pull request as draft May 20, 2024 16:55
ryantrem
ryantrem approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@ryantrem ryantrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run through the manual test script for both iOS and Android?

@CedricGuillemet
Copy link
Contributor Author

Did you run through the manual test script for both iOS and Android?

not yet. I need to do a dry run of npm publish as well.

@CedricGuillemet CedricGuillemet marked this pull request as ready for review May 23, 2024 07:39
@CedricGuillemet CedricGuillemet changed the title Update BN and BJS version to 7.6.2 Update BN May 23, 2024
@CedricGuillemet CedricGuillemet mentioned this pull request May 23, 2024
Merged
@CedricGuillemet CedricGuillemet merged commit 17b16ca into master May 24, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantrem ryantrem ryantrem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependency Conflict When Initializing App
2 participants
@CedricGuillemet @ryantrem