Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unittests #44

Merged
merged 12 commits into from
Aug 4, 2023
Merged

Fix unittests #44

merged 12 commits into from
Aug 4, 2023

Conversation

CedricGuillemet
Copy link
Contributor

@CedricGuillemet CedricGuillemet commented Aug 2, 2023 •
edited
Loading

  • reorder CI win32 job to fix the artifact publish
  • Fix websocket cancellation with this related PR : WebSocket Windows Cancellation UrlLib#8
  • removed setimeout workaround for Mocha exitCode
  • changed the reporter from tap to spec. The tap reporter makes extra calls to settimeout that cause extra async operation after setting exit code. This does not happen with spec

I kicked 5 pipeline runs and 1 Android JSC job failed because it was not able to start android emulator, so issue seams to be gone.

@CedricGuillemet CedricGuillemet mentioned this pull request Aug 3, 2023
Closed
@CedricGuillemet CedricGuillemet merged commit 17c8128 into main Aug 4, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bghgary bghgary bghgary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CedricGuillemet @bghgary