Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8 inspector and error handling fixes #84

Merged
merged 7 commits into from
Mar 20, 2024
Merged

Conversation

bghgary
Copy link
Contributor

@bghgary bghgary commented Mar 13, 2024

  • Remove dead code in V8 inspector
  • Fix race condition on V8 inspector shutdown
  • Add options struct to AppRuntime to support new WaitForDebugger flag
  • Use new WaitForDebugger flag in JavaScript tests
  • Remove newline from console log callback

Fixes #21
Fixes #61

- Remove dead code in V8 inspector
- Fix race condition on V8 inspector shutdown
- Add options struct to AppRuntime to support new WaitForDebugger flag
- Use new WaitForDebugger flag in JavaScript tests
- Remove newline from console log callback
@bghgary bghgary changed the title - Fix V8 inspector to run correctly on Windows - V8 inspector and error handling fixes Mar 19, 2024
@bghgary bghgary marked this pull request as ready for review March 19, 2024 21:46
Copy link

@SergioRZMasson SergioRZMasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bghgary bghgary changed the title - V8 inspector and error handling fixes V8 inspector and error handling fixes Mar 20, 2024
@bghgary bghgary merged commit 5f20827 into BabylonJS:main Mar 20, 2024
16 checks passed
@bghgary bghgary deleted the debugger branch March 20, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants