Comments are displayed with a different indentation

[luruke]

Hi there!

When I inspect or edit the following shader:

    precision highp float;
    
    uniform vec3 color; // ms({ value: '#ff0000' })
    uniform float brightness; // ms({ value: 0, range: [0, 0.5], step: 0.1 })
    uniform vec2 dummyValue; // ms({ value: [1024, 768], range: [[0, 2000], [0, 1500]] })
    uniform bool visible; // ms({ value: 1, name: 'Visibility' })
    uniform int test; // ms({ value: 0 })

    void main() {
      gl_FragColor = vec4(color + brightness, 1.0);
    }

is displayed like this:

and by consequence, after edited, the shader is broken.

[luruke]

I guess the problem it's here?

Spector.js/src/embeddedFrontend/resultView/sourceCode/sourceCodeComponent.ts

Line 136 in 64e3269

I guess the identation should be avoided if it's a comment

[sebavan]

ohhhhh you are totally right, Good catch :-)

I will fix it ASAP.

[luruke]

@sebavan , thanks for the quick reply...who ever thought to put curly brackets in comments, right? 😅

[sebavan]

Lol, I have to admit I did not hit this one so far :-)

[sebavan]

Do you have a live URL I could validate the fix on ?

[luruke]

Hey @sebavan , much better, but comments goes on a new line:

I do not have a live link..but you can try it on this repo:

git clone git@github.com:luruke/magicshader.git
cd magicshader
npm install
npm run dev

Would it be possible to keep them on the same line as the original shader source?

[sebavan]

I can repro locally, do you have a strong deadline on this one ?

It sounds a bit lower priority as it does not break the full edition, and I am trying atm to move the front end to React to ease the contribution. Is a fix by end of week OK ?

[luruke]

Hey @sebavan , no worries, there is no deadline 👍😊

[sebavan]

Sweeet I will redeploy at the end of the week then.

[luruke]

Hi @sebavan, Is there any news on this?
Can I help you somehow?

Cheers!

[sebavan]

Yup the migration to React is delaying me a bit, but if you want you can definitely help by taking a look at the beautify method :-) cause I won t be able to work on it before at least another week

[luruke]

@sebavan ok, thanks. I'll see If I can do a PR :)

[sebavan]

Thanks a ton