Corrected a bug when getting UBO value. #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the uniform block's index instead of its binding point.
|
I just noticed it didn't solve the problem when using the extension, maybe I'm just missing something in the build process. I'll reopen this when I figured it out. |
|
To solve in the extension you need to nom run build and install the extension locally. I do not see any issue with the pr tou can reopen it and i ll merge in the morning |
|
Ah yes right, perfect. I thought "npm start" would rebuild everything on file change, including the extension. I just tried and it solves the repro case and my original case :). Merge away! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buffer was retrieved using the uniform block's index instead of its binding point.