Stringify stencilFuncSeparate #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JannikGM
commented
Oct 28, 2021
| protected stringifyArgs(args: IArguments): string[] { | ||
| const stringified = []; | ||
| stringified.push(WebGlConstants.stringifyWebGlConstant(args[0], "stencilFuncSeparate")); | ||
| stringified.push(WebGlConstants.stringifyWebGlConstant(args[1], "stencilFuncSeparate")); |
There was a problem hiding this comment.
nit: I don't like how the command name is typed out here; it would probably be smarter to use the static commandName variable? However, explicitly writing it out is how it's done everywhere.
JannikGM
commented
Oct 28, 2021
| @@ -139,6 +140,7 @@ export class CommandSpy { | |||
| [GetShaderPrecisionFormat.commandName]: (options: IContextInformation) => new GetShaderPrecisionFormat(options), | |||
| [GetTransformFeedbackVarying.commandName]: (options: IContextInformation) => new GetTransformFeedbackVarying(options), | |||
| [Scissor.commandName]: (options: IContextInformation) => new Scissor(options), | |||
| [StencilFuncSeparate.commandName]: (options: IContextInformation) => new StencilFuncSeparate(options), | |||
There was a problem hiding this comment.
It would probably make sense to also addstencilFunc support, but I only ran into this issue with stencilFuncSeparate and needed a fix asap.
Ideally some code could be factored out, or it could be part of the same file?
JannikGM
force-pushed
the
stencilFuncSeparate
branch
from
4197a15
to
f9d3770
Compare
JannikGM
commented
Oct 28, 2021
sebavan
approved these changes
Oct 28, 2021
|
Thanks a lot @JannikGM !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Barely tested; but binary display should help when working with stencil planes.
Before this PR, spector.js would even try to figure out WebGL names for the last 2 arguments, which would always be some meaningless enum constant.