Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes texture display when a uniforms is bound to a texture array #224

Merged
merged 6 commits into from Jan 21, 2022

Conversation

akarimgc
Copy link

  • Adds correct parsing for the instance where a uniform is an array of textures.
  • In this case we need to bind to values[].value for the texture unit.

@sebavan
Copy link
Member

sebavan commented Jan 19, 2022

Thanks a ton !!! could you remove the dist built files from the PR and drop a line in the changelogs.md ?

@akarimgc
Copy link
Author

Thanks a ton !!! could you remove the dist built files from the PR and drop a line in the changelogs.md ?

Thanks @sebavan. Have removed the dist files and updated the changelogs with a new entry for v0.9.29 not sure if that's what you meant.

@sebavan
Copy link
Member

sebavan commented Jan 19, 2022

Oh sorry a last change :-( could you move the line in v0.9.28 ? this will be the next release :-) The doc is always one version in advance to prep the next release (agree it is not obvious) I ll merge right after

@akarimgc
Copy link
Author

Oh sorry a last change :-( could you move the line in v0.9.28 ? this will be the next release :-) The doc is always one version in advance to prep the next release (agree it is not obvious) I ll merge right after

Hey @sebavan moved the changelog entry. Took me a while to circle back!

@sebavan
Copy link
Member

sebavan commented Jan 21, 2022

Perfect, thanks a lot !!!

@sebavan sebavan merged commit 8fa804c into BabylonJS:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants