Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to toggle GLSL preprocess #295

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

06wj
Copy link
Contributor

@06wj 06wj commented Dec 28, 2023

Added a switch for shader preprocess, making it easier to understand the shader and get rid of any unnecessary distractions.

@06wj
Copy link
Contributor Author

06wj commented Dec 28, 2023

I use @shaderfrog/glsl-parser to do the preprocess.It supports both GLSL 1.0 and GLSL 3.0.
See more: https://github.com/ShaderFrog/glsl-parser?tab=readme-ov-file#state-of-this-library

@06wj 06wj force-pushed the master branch 3 times, most recently from 3f1ec77 to 4264a30 Compare December 28, 2023 17:05
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks great on what I tried !!!

@sebavan sebavan merged commit 8250ccd into BabylonJS:master Jan 2, 2024
1 check passed
@cx20
Copy link

cx20 commented Jan 6, 2024

@sebavan Is it possible to get the improved Spector.js from the Chrome Web Store?
The version currently registered in the Store seems to be 0.9.28 (2022-08-02).
https://chromewebstore.google.com/detail/spectorjs/denbgaamihkadbghdceggmchnflmhpmk

@sebavan
Copy link
Member

sebavan commented Jan 9, 2024

You are totally right, I ll try to do later today !!!

@sebavan
Copy link
Member

sebavan commented Jan 11, 2024

So sorry it takes time @cx20 I will go over it this weekend, work is pretty busy at the moment.

@sebavan
Copy link
Member

sebavan commented Feb 1, 2024

It should be deployed soon on the Chrome Web Store sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants