New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent formulation of SH_reconstruct #165

Open

cosw0t opened this issue Jul 5, 2021 · 0 comments

Contributor

cosw0t commented Jul 5, 2021 •

edited

Loading

The formulations of SH_reconstruct for rectangular envmaps in pytorch and tensorflow are inconsistent in that the returned envmaps are of shape:

(res[0], res[1], coeffs.shape[0]) for pytorch
(res[1], res[0], coeffs.shape[0]) for tensorflow

which one is the intended one?

also the pytorch one doesn't work in the first place because of this line:

https://github.com/BachiLi/redner/blob/master/pyredner/utils.py#L58-59

    result = torch.max(result,
        torch.zeros(res[1], res[0], coeffs.shape[0], device = coeffs.device))

where the indices for res are wrong?

The last problem can be easily fixed (#166 ) however the original question still remains.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment