add pmd xml driver #117
Merged
add pmd xml driver #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Method checks if the provided tool is installed. | ||
| Returns: boolean False: As findbugs analyses bytecode, it would be hard to run it from outside the build framework. | ||
| """ | ||
| return True |
There was a problem hiding this comment.
I think you want return False here.
Diff-cover is unlikely to be running findbugs, instead it will be parsing a report provided by the user.
If you intend to have diff-cover run findbugs this PR is going to need a bit more work to actually be able to run it.
| for report in reports: | ||
| xml_document = cElementTree.fromstring("".join(report)) | ||
| files = xml_document.findall(".//file") | ||
| for file in files: |
There was a problem hiding this comment.
Please rename the file variable here.
File is a type in python so using it as a variable name can be confusing.
>>> file
<type 'file'>
|
Thanks for the PR! This is a good start! I left some notes but the bug thing is I cannot merge this unless it has some tests to cover the code being added here |
|
code updated |
|
Thanks for adding tests. I'll give this a final review and try and get it released by tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.