New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pmd xml driver #117
Merged
Merged
add pmd xml driver #117
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ | |
""" | ||
from __future__ import unicode_literals | ||
|
||
import os | ||
from collections import defaultdict | ||
|
||
from xml.etree import cElementTree | ||
|
@@ -115,3 +116,46 @@ def installed(self): | |
Returns: boolean False: As findbugs analyses bytecode, it would be hard to run it from outside the build framework. | ||
""" | ||
return False | ||
|
||
|
||
class PmdXmlDriver(QualityDriver): | ||
def __init__(self): | ||
""" | ||
See super for args | ||
""" | ||
super(PmdXmlDriver, self).__init__( | ||
'pmd', | ||
['java'], | ||
[] | ||
) | ||
|
||
def parse_reports(self, reports): | ||
""" | ||
Args: | ||
reports: list[str] - output from the report | ||
Return: | ||
A dict[Str:Violation] | ||
Violation is a simple named tuple Defined above | ||
""" | ||
violations_dict = defaultdict(list) | ||
for report in reports: | ||
xml_document = cElementTree.fromstring("".join(report)) | ||
files = xml_document.findall(".//file") | ||
for file in files: | ||
for error in file.findall('violation'): | ||
line_number = error.get('beginline') | ||
error_str = "{}: {}".format(error.get('rule'), | ||
error.text.strip()) | ||
violation = Violation(int(line_number), error_str) | ||
filename = GitPathTool.relative_path(file.get('name')) | ||
filename = filename.replace(os.sep, "/") | ||
violations_dict[filename].append(violation) | ||
|
||
return violations_dict | ||
|
||
def installed(self): | ||
""" | ||
Method checks if the provided tool is installed. | ||
Returns: boolean False: As findbugs analyses bytecode, it would be hard to run it from outside the build framework. | ||
""" | ||
return True | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you want Diff-cover is unlikely to be running findbugs, instead it will be parsing a report provided by the user. If you intend to have diff-cover run findbugs this PR is going to need a bit more work to actually be able to run it. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename the
file
variable here.File is a type in python so using it as a variable name can be confusing.