New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running diff-quality with a tool which is not installed gives FIleNotFoundError rather than helpful "<tool> is not installed" error message #378
Comments
dperl-dls
added a commit
to dperl-dls/diff_cover
that referenced
this issue
Dec 13, 2023
dperl-dls
added a commit
to dperl-dls/diff_cover
that referenced
this issue
Dec 13, 2023
I dont mind a dupe when Ican get more details (not to mention a pr). Running the test suite now |
dperl-dls
added a commit
to dperl-dls/diff_cover
that referenced
this issue
Dec 14, 2023
@dperl-dls https://pypi.org/project/diff-cover/8.0.2/ is released with your PR in it. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce:
diff_cover
diff-quality --violations=pydocstyle
Failure: '[Errno 2] No such file or directory: 'pydocstyle''
Expected behaviour:
The output is instead
Failure: 'pydocstyle is not installed'
Suggested resolution:
If
diff_cover.command_runner.run_command_for_code
is edited to be:Then the output is as expected. Setting
shell=True
inPopen
equally works. See https://docs.python.org/3.11/library/subprocess.html#exceptionsEdit: I see this is actually a dupe of #303, sorry about that
The text was updated successfully, but these errors were encountered: