Implement --diff-range-notation option #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. I left a question and curious on your thinking. But if you feel strongly about leaving it as is im happy to leave it and merge |
addCleanup is considered more resilient and safer because tearDown methods are not executed in case the setUp method fails. They also bring resource creation and deletion closer together, facilitating refactorings.
|
After you are happy with this changes and this gets merged, could we have another release? I'm happy to open the PR preparing the release if that helps. I don't see instructions on how to make a release, but from what I can gather:
|
|
Woot! Thanks for all the work on this. Ill handle getting the release out. let me look at one other PR and get this done tonight |
|
Awesome, thanks! |
|
just crossing my fingers hoping my recently added 2fa did not break the travis CD pipeline.... |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also used
self.addCleanupto undo setup changes in a few places, after noticing that the patches intest_git_diff.pywere not being undone.addCleanupis considered more resilient and safer becausetearDownmethods are not executed in case thesetUpmethod fails, which might leave resources around.They also bring resource creation and deletion closer together, facilitating refactorings.
Fix #105