Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pre-commit hooks #317

Closed
wants to merge 1 commit into from
Closed

chore: add pre-commit hooks #317

wants to merge 1 commit into from

Conversation

yibuma
Copy link

@yibuma yibuma commented Feb 6, 2023

Add .pre-commit-hooks.yaml file.
Add integration of Pre-commit in README.
pre-commit is A framework for managing and maintaining multi-language pre-commit hooks. add .pre-commit-hooks.yaml makes it easier to use the git hook.

Add integration of Pre-commit in README.
pre-commit is A framework for managing and maintaining multi-language pre-commit hooks.
add .pre-commit-hooks.yaml makes it easier to use the git hook.
@Bachmann1234
Copy link
Owner

I appreciate you checking out the project. Precommit is a cool project and useful at times. But im not terribly interested in adding it to this project. I am comfortable setting up hooks by managing .git/hooks

Most contributors make the occasional PR and CI runs fast enough its not a huge burden let PR CI cover them.

@yibuma
Copy link
Author

yibuma commented Feb 7, 2023

Thank you for the explanation, I have understood.
That is good, it will make the repository cleaner.

@yibuma yibuma closed this Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants