Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shellcheck violation tool in diff-quality #347

Merged
merged 1 commit into from Jun 11, 2023

Conversation

mg-cloud
Copy link
Contributor

@mg-cloud mg-cloud commented Jun 6, 2023

No description provided.

@Bachmann1234
Copy link
Owner

This is looking good, Found a typo in the comments and the build is failing cuse you need to format the code with black. But I can take another look after that.

Thanks for the PR!

@mg-cloud
Copy link
Contributor Author

mg-cloud commented Jun 7, 2023

This is looking good, Found a typo in the comments and the build is failing cuse you need to format the code with black. But I can take another look after that.

Thanks for the PR!

Fixed the typo and use black to format the change. Thx for the review

@Bachmann1234
Copy link
Owner

Alright, lets get this merged! Thanks for the PR!

@Bachmann1234 Bachmann1234 merged commit a84e65e into Bachmann1234:main Jun 11, 2023
7 checks passed
@Bachmann1234
Copy link
Owner

@mg-castel released https://pypi.org/project/diff-cover/7.6.0/!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants