Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line numbers to Markdown code snippets #399

Merged
merged 3 commits into from Apr 14, 2024

Conversation

walles
Copy link
Contributor

@walles walles commented Apr 11, 2024

With these changes

  37 
  38 	}
  39 
  40 	private static void untested() {
! 41 		System.out.println("This method has no tests");
! 42 	}
  43 
  44 }

Before


	}

	private static void untested() {
		System.out.println("This method has no tests");
	}

}

@walles walles marked this pull request as ready for review April 11, 2024 18:30
@walles
Copy link
Contributor Author

walles commented Apr 12, 2024

Sorry about the test failures, will fix.

@walles walles marked this pull request as draft April 12, 2024 05:43
@walles walles marked this pull request as ready for review April 12, 2024 05:56
@walles
Copy link
Contributor Author

walles commented Apr 12, 2024

Tests pass for me locally now.

Copy link
Owner

@Bachmann1234 Bachmann1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, merging this in.

@Bachmann1234 Bachmann1234 merged commit 411c5ff into Bachmann1234:main Apr 14, 2024
7 checks passed
@Bachmann1234
Copy link
Owner

Released in https://pypi.org/project/diff-cover/9.0.0/

Thanks again!

@walles walles deleted the johan/markdown-linenums branch April 15, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants