Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kwargs to `_[de]serialize(...) #28

Merged
merged 1 commit into from
Jul 6, 2019
Merged

Add kwargs to `_[de]serialize(...) #28

merged 1 commit into from
Jul 6, 2019

Conversation

palango
Copy link
Contributor

@palango palango commented Jul 5, 2019

This seems to be a recent change in marshmallow but is shown in the docs
at
https://marshmallow.readthedocs.io/en/3.0/custom_fields.html#creating-a-field-class

The original bug report that led to this being found: marshmallow-code/marshmallow#1286

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1896423 on palango:add-kwargs into 5286045 on Bachmann1234:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1896423 on palango:add-kwargs into 5286045 on Bachmann1234:master.

@sloria
Copy link
Contributor

sloria commented Jul 5, 2019

To get the tests passing, you'll also need to add **kwargs to the make_object methods (and any other decorated processor methods, if any).

@Bachmann1234
Copy link
Owner

Bachmann1234 commented Jul 5, 2019

Thank you for the PR! Glad to see this caught and fixed!

I would be happy to merge and release this weekend if the tests were passing

@palango
Copy link
Contributor Author

palango commented Jul 6, 2019

@Bachmann1234 @sloria I thought this was a quick fix, but I'm busy this weekend unfortunately. But feel free to either push changes to this PR or take it and continue in another PR.

@Bachmann1234 Bachmann1234 merged commit c664f3d into Bachmann1234:master Jul 6, 2019
@Bachmann1234
Copy link
Owner

Completed over here #29

Release going out shortly

@Bachmann1234
Copy link
Owner

Release out https://pypi.org/project/marshmallow-polyfield/5.7/

@palango palango deleted the add-kwargs branch July 8, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants