Use _have instead of have for bash completion
#497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`have` is deprecated[1] and gets unset at the end of bash_completion[2] which can cause issues in certain situations (specifically when running bash_completion on NixOS - because the script is evaluated at the start[3] but can't finish properly because `have` is already unset at that point) [1] https://github.com/scop/bash-completion/blob/4d88339928aa064a567d5feb40694dfd24a274c5/bash_completion#L114 [2] https://github.com/scop/bash-completion/blob/4d88339928aa064a567d5feb40694dfd24a274c5/bash_completion#L2103 [3] https://github.com/NixOS/nixpkgs/blob/80b6513fbf5789ff0208c19a89bae49df2b503ad/nixos/modules/programs/bash/bash.nix#L22
uskudnik
changed the title
_have instead of have_have instead of have for bash completion
9 tasks
|
Problem... This commit causes To appear on every Terminal launch.
|
uskudnik
added a commit
to uskudnik/nixpkgs
that referenced
this pull request
Sep 3, 2018
backblaze v1.3.6 incorporates[1] a fix[2] for autocompletion that replaced `have` function with `_have`. The postInstall hook therefore needs to be updated to replace `_have`. [1] https://github.com/Backblaze/B2_Command_Line_Tool#136-august-21-2018 [2] Backblaze/B2_Command_Line_Tool#497
9 tasks
domenkozar
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Sep 3, 2018
backblaze v1.3.6 incorporates[1] a fix[2] for autocompletion that replaced `have` function with `_have`. The postInstall hook therefore needs to be updated to replace `_have`. [1] https://github.com/Backblaze/B2_Command_Line_Tool#136-august-21-2018 [2] Backblaze/B2_Command_Line_Tool#497
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
haveis deprecated and gets unset at the end ofbash_completion which can cause issues in certain situations
(specifically when running bash_completion on NixOS - because
the script is evaluated at the start but can't finish properly
because
haveis already unset at that point).