Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_upload_url_concurrency not in test/ directory #471

Closed
Hawk777 opened this issue Feb 2, 2024 · 4 comments · Fixed by #472
Closed

test_upload_url_concurrency not in test/ directory #471

Hawk777 opened this issue Feb 2, 2024 · 4 comments · Fixed by #472
Labels
good first issue Good for newcomers

Comments

@Hawk777
Copy link
Contributor

Hawk777 commented Feb 2, 2024

I’m not certain if this is intentional or accidental, but test_upload_url_concurrency is in the main package source directory rather than the test/ directory, despite being a test.

@vbaltrusaitis-reef
Copy link
Collaborator

This file is ancient and it's not a part of the test suite that is run with nox or otherwise in CI, it's more of a "test script" than an actual test. It should be either incorporated into the test suite or perhaps simply removed.

@ppolewicz ppolewicz added the good first issue Good for newcomers label Feb 3, 2024
@ppolewicz
Copy link
Collaborator

I don't think anyone used it for many years now.

@Hawk777 since this is your finding, would you like to do the honors?

@Hawk777
Copy link
Contributor Author

Hawk777 commented Feb 3, 2024

You’d like the test deleted?

@ppolewicz
Copy link
Collaborator

Yes, and the changelog needs to mention it (please see a note about how to use towncrier)

Hawk777 added a commit to Hawk777/b2-sdk-python that referenced this issue Feb 4, 2024
Hawk777 added a commit to Hawk777/b2-sdk-python that referenced this issue Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants