Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing circular symlinks (issue 513) #390

Merged
merged 26 commits into from
May 23, 2023
Merged

Fixing circular symlinks (issue 513) #390

merged 26 commits into from
May 23, 2023

Commits on May 1, 2023

  1. Fixing circular symlinks (issue 513) 

    Capped symlinks visits while scanning
New tests added
Added pytest-timeout to test requirements
Changelog updated
    @przadka
    przadka committed May 1, 2023
    Configuration menu
    Copy the full SHA
    d770d0e View commit details
    Browse the repository at this point in the history

  2. Improved symlinks compatibility with Windows

    @przadka
    przadka committed May 1, 2023
    Configuration menu
    Copy the full SHA
    0ac51c0 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Changelog updated properly

    @przadka
    przadka committed May 2, 2023
    Configuration menu
    Copy the full SHA
    6559deb View commit details
    Browse the repository at this point in the history

  2. Refactored _walk_relative_paths to use pathlib

    @przadka
    przadka committed May 2, 2023
    Configuration menu
    Copy the full SHA
    447d706 View commit details
    Browse the repository at this point in the history

  3. Improved _walk_relative_paths signature

    @przadka
    przadka committed May 2, 2023
    Configuration menu
    Copy the full SHA
    e0b71d8 View commit details
    Browse the repository at this point in the history

  4. Removed redundant asserts

    @przadka
    przadka committed May 2, 2023
    Configuration menu
    Copy the full SHA
    0375f8c View commit details
    Browse the repository at this point in the history

  5. Test refactoring after PR

    @przadka
    przadka committed May 2, 2023
    Configuration menu
    Copy the full SHA
    1e0e43f View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. PR feedback implemented 

    Circular loops are not detected as soon as we visit the same path twice
Improved docstring for _walk_relative_paths
    @przadka
    przadka committed May 4, 2023
    Configuration menu
    Copy the full SHA
    502e970 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Directory traversal refactored 

    No longer secretly skipping symlinks pointing to parent of scan directory
Added warning msg when circular symlinks found
Set of visited symlinks now stores inode integers rather than full paths
    @przadka
    przadka committed May 5, 2023
    Configuration menu
    Copy the full SHA
    4a0e1df View commit details
    Browse the repository at this point in the history

  2. Tests refactored to improved readability

    @przadka
    przadka committed May 5, 2023
    Configuration menu
    Copy the full SHA
    1cc6d2a View commit details
    Browse the repository at this point in the history

  3. Typo fixed

    @przadka
    przadka committed May 5, 2023
    Configuration menu
    Copy the full SHA
    74e1c07 View commit details
    Browse the repository at this point in the history

  4. Refactoring - moved tests to a separate file

    @przadka
    przadka committed May 5, 2023
    Configuration menu
    Copy the full SHA
    20d475f View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. PR feedback implemented

    @przadka
    przadka committed May 9, 2023
    Configuration menu
    Copy the full SHA
    bab887b View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Disabling yapf to allow long lines 

    Co-authored-by: Paweł Polewicz <p.polewicz@gmail.com>
    @przadka @ppolewicz
    przadka and ppolewicz committed May 10, 2023
    Configuration menu
    Copy the full SHA
    2ce6eb7 View commit details
    Browse the repository at this point in the history

  2. Lines with paths are now longer and more readable

    @przadka
    przadka committed May 10, 2023
    Configuration menu
    Copy the full SHA
    b6ecacf View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Refactored symlinks set to improve performance

    @przadka
    przadka committed May 15, 2023
    Configuration menu
    Copy the full SHA
    64be896 View commit details
    Browse the repository at this point in the history

  2. Refactor directory iteration to use generator expression instead of l… 

    …ist comprehension to reduce memory usage

Co-authored-by: Paweł Polewicz <p.polewicz@gmail.com>
    @przadka @ppolewicz
    przadka and ppolewicz committed May 15, 2023
    Configuration menu
    Copy the full SHA
    b11addb View commit details
    Browse the repository at this point in the history

  3. Update test readability 

    Co-authored-by: Paweł Polewicz <p.polewicz@gmail.com>
    @przadka @ppolewicz
    przadka and ppolewicz committed May 15, 2023
    Configuration menu
    Copy the full SHA
    24595c7 View commit details
    Browse the repository at this point in the history

  4. Removed redundant comment 

    Co-authored-by: Paweł Polewicz <p.polewicz@gmail.com>
    @przadka @ppolewicz
    przadka and ppolewicz committed May 15, 2023
    Configuration menu
    Copy the full SHA
    f2d80a9 View commit details
    Browse the repository at this point in the history

  5. Removed unused re import

    @przadka
    przadka committed May 15, 2023
    Configuration menu
    Copy the full SHA
    634cd70 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. New tests added after PR feedback.

    @przadka
    przadka committed May 16, 2023
    Configuration menu
    Copy the full SHA
    1e6098d View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. Refactored relative symlinks paths in tests

    @przadka
    przadka committed May 19, 2023
    Configuration menu
    Copy the full SHA
    34e8ab9 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2023

  1. New test added

    @przadka
    przadka committed May 20, 2023
    Configuration menu
    Copy the full SHA
    29d667b View commit details
    Browse the repository at this point in the history

  2. Added unused imports to test CI

    @przadka
    przadka committed May 20, 2023
    Configuration menu
    Copy the full SHA
    86d1616 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Disable yapf only where necessary

    @ppolewicz
    ppolewicz committed May 23, 2023
    Configuration menu
    Copy the full SHA
    d2bfb40 View commit details
    Browse the repository at this point in the history

  2. Polishing style in test/unit/scan/test_folder_traversal.py

    @ppolewicz
    ppolewicz committed May 23, 2023
    Configuration menu
    Copy the full SHA
    09a8a3d View commit details
    Browse the repository at this point in the history