Remove dependency from tqdm #393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Projects like B2CLI should require it directly. The sdk generally works fine without that dependency which pulls its own dependencies and it is a problem for some projects. We'll continue to support classes that use tqdm. Any existing installations should keep their dependency in their venv and new versions of the CLI as well as any other console applications should depend on tqdm directly, if they choose to use it.
miketheman
approved these changes
May 30, 2023
|
Ok so the problem is that TqdmProgressReporter was (by mistake) a part of the public interface so now removing the dependency will potentially break the clients using that class (if they didn't require tqdm directly). In order to fix it we will make a major version release, b2-sdk-python 2.0.0 - but before we do, we'll review the other public classes to make sure this type of a problem is not going to happen again with some other class. |
|
Continued in #487 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Projects like B2CLI should require it directly. The sdk generally works fine without that dependency which pulls its own dependencies and it is a problem for some projects. We'll continue to support classes that use tqdm.
Any existing installations should keep their dependency in their venv and new versions of the CLI as well as any other console applications should depend on tqdm directly, if they choose to use it.