-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename file_infos parameter #397
Merged
ppolewicz
merged 10 commits into
Backblaze:master
from
mjurbanski-reef:rename_file_infos
Jun 15, 2023
Merged
Rename file_infos parameter #397
ppolewicz
merged 10 commits into
Backblaze:master
from
mjurbanski-reef:rename_file_infos
Jun 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppolewicz
reviewed
Jun 13, 2023
b2sdk/v2/bucket.py
Outdated
Comment on lines
31
to
58
@_file_infos_rename | ||
def upload_bytes( | ||
self, | ||
data_bytes, | ||
file_name, | ||
content_type=None, | ||
file_info: dict | None = None, | ||
progress_listener=None, | ||
encryption: v3.EncryptionSetting | None = None, | ||
file_retention: v3.FileRetentionSetting | None = None, | ||
legal_hold: v3.LegalHold | None = None, | ||
large_file_sha1: Sha1HexDigest | None = None, | ||
custom_upload_timestamp: int | None = None, | ||
cache_control: str | None = None, | ||
): | ||
return super().upload_bytes( | ||
data_bytes=data_bytes, | ||
file_name=file_name, | ||
content_type=content_type, | ||
file_info=file_info, | ||
progress_listener=progress_listener, | ||
encryption=encryption, | ||
file_retention=file_retention, | ||
legal_hold=legal_hold, | ||
large_file_sha1=large_file_sha1, | ||
custom_upload_timestamp=custom_upload_timestamp, | ||
cache_control=cache_control, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
@_file_infos_rename | |
def upload_bytes( | |
self, | |
data_bytes, | |
file_name, | |
content_type=None, | |
file_info: dict | None = None, | |
progress_listener=None, | |
encryption: v3.EncryptionSetting | None = None, | |
file_retention: v3.FileRetentionSetting | None = None, | |
legal_hold: v3.LegalHold | None = None, | |
large_file_sha1: Sha1HexDigest | None = None, | |
custom_upload_timestamp: int | None = None, | |
cache_control: str | None = None, | |
): | |
return super().upload_bytes( | |
data_bytes=data_bytes, | |
file_name=file_name, | |
content_type=content_type, | |
file_info=file_info, | |
progress_listener=progress_listener, | |
encryption=encryption, | |
file_retention=file_retention, | |
legal_hold=legal_hold, | |
large_file_sha1=large_file_sha1, | |
custom_upload_timestamp=custom_upload_timestamp, | |
cache_control=cache_control, | |
) | |
@_file_infos_rename | |
def upload_bytes( | |
self, | |
data_bytes, | |
file_name, | |
content_type=None, | |
file_info: dict | None = None, | |
progress_listener=None, | |
encryption: v3.EncryptionSetting | None = None, | |
file_retention: v3.FileRetentionSetting | None = None, | |
legal_hold: v3.LegalHold | None = None, | |
large_file_sha1: Sha1HexDigest | None = None, | |
custom_upload_timestamp: int | None = None, | |
cache_control: str | None = None, | |
*args, | |
**kwargs | |
): | |
return super().upload_bytes( | |
*args, | |
data_bytes=data_bytes, | |
file_name=file_name, | |
content_type=content_type, | |
file_info=file_info, | |
progress_listener=progress_listener, | |
encryption=encryption, | |
file_retention=file_retention, | |
legal_hold=legal_hold, | |
large_file_sha1=large_file_sha1, | |
custom_upload_timestamp=custom_upload_timestamp, | |
cache_control=cache_control, | |
**kwargs | |
) |
Future-proofing - if someone adds an argument, we want it to be visible in v2 too and we do not want to rely on someone remembering it should be added here too.
ppolewicz
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.