Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backbone and underscore should be dependencies (not devDependencies) #46

Closed
xMartin opened this issue Oct 14, 2014 · 1 comment · Fixed by #54
Closed

Backbone and underscore should be dependencies (not devDependencies) #46

xMartin opened this issue Oct 14, 2014 · 1 comment · Fixed by #54

Comments

@xMartin
Copy link
Contributor

xMartin commented Oct 14, 2014

Backbone and underscore should be dependencies, not devDependencies in package.json because these are necessary to run the code and should always be installed when using npm.
@geekdave
Copy link
Contributor

Right you are - mind submitting a PR?

amakhrov pushed a commit to amakhrov/backbone.subroute that referenced this issue May 12, 2015
BackboneSubroute#46 Move backbone and underscore from devDeps to deps…
3612467 
… in package.json
@amakhrov amakhrov mentioned this issue May 12, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix deps package json amakhrov/backbone.subroute
2 participants
@xMartin @geekdave