Fixed a bug that would cause initial loading to not happen correctly if prefix contained parameters #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekdave
added a commit
that referenced
this pull request
Jul 13, 2013
Fixed a bug that would cause initial loading to not happen correctly if prefix contained parameters
|
Sorry for the delay! Just tested this on my own projects and it works great. Had not thought of this use case yet, but I think I will be useful. Thanks! Merging... Closes #22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you wanted the prefix to contain a parameter, say #user/:username/*subroute the SubRoute would never match because you were trying to match #user/:username/... to #user/somerandomusername/... The method of matching has been changed to regex matching versus determining if two strings matched.