Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make utf-8 eci prefix configurable #130

Merged
merged 3 commits into from Sep 5, 2023

Conversation

weiting-sflx
Copy link
Contributor

Motivation

Some barcode scanners won't be able to read QR code that is prepended with UTF-8 ECI block, so we want to make the prefix configurable in the library that we utilize in our project endroid/qr-code-bundle

Changes

  • Add a new parameter to the Encoder::encode function
  • Adjust the Dockerfile

While building the docker image, we ran into errors and some depenencies were missing. After the modification, we were able to build the image and conducted the tests.

@DASPRiD DASPRiD merged commit 8eba389 into Bacon:master Sep 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants