Refactor #8
Refactor #8
Conversation
| $this->slugifier = $slugifier; | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
I'm actually wondering… do we need this getter at all?
There was a problem hiding this comment.
In module we don't use it, but someone want to get it.
There was a problem hiding this comment.
I don't really see any reason for it. After all, they may get it through the service manager.
There was a problem hiding this comment.
What if you want to check slugifier in filter? You don't see reason to keep it, I don't see reason to remote it.
|
Also, make sure to fix the build. |
|
@DASPRiD Travis fail on a test. Can you restart it manually? |
|
Actually PHPCS fails. |
|
I have pushed new commit 'Fix coding standard', but test failed on composer |
|
I see. Well, I cannot restart travis on pull requests. |
|
@DASPRiD Green light :-) |
|
@DASPRiD should I fix something more? |
| * | ||
| * @link http://github.com/Bacon/BaconStringUtils For the canonical source repository | ||
| * @copyright 2011-2014 Ben Scholzen 'DASPRiD' | ||
| * @author Witold Wasiczko <witold@wasiczko.pl> |
Remove static, factories, remove extend in filter, extends service providers and more test