fix #308 #411
Merged
fix #308 #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadChoice
approved these changes
Feb 11, 2020
BadChoice
requested changes
Feb 11, 2020
| @@ -4,7 +4,9 @@ | |||
| Route::resource('tickets', 'TicketsController', ['except' => 'destroy']); | |||
| Route::post('tickets/{ticket}/comments', 'CommentsController@store'); | |||
| Route::post('tickets/{ticket}/assign', 'TicketAssignController@store'); | |||
| Route::post('users/create', 'UsersController@store'); | |||
There was a problem hiding this comment.
actually the create is not required, a simple post to users will create them
There was a problem hiding this comment.
Well an endpoint to create and one to list them, I can change the endpoint name in case
There was a problem hiding this comment.
yes, POST users to create one, GET users list them
There was a problem hiding this comment.
GET users/{user_id} to the full info of one
| $users=new User; | ||
| $users->name=$request->get('name'); | ||
| $users->email=$request->get('email'); | ||
| $users->password=Hash::make($request->get('password')); |
There was a problem hiding this comment.
we usually use the bcrypt method bcrypt($request('password'))
There was a problem hiding this comment.
I saw that in the handesk code is used hash
|
So I don't need to add any tests for that? |
|
A test would be great!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add 2 new endpoints:
Require a bit of testing because I cannot find how to use the endpoints in handesk