Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RRSIG records aren't process correctly #75

Closed
emkookmer opened this issue Aug 3, 2020 · 2 comments
Closed

RRSIG records aren't process correctly #75

emkookmer opened this issue Aug 3, 2020 · 2 comments
Milestone

Comments

@emkookmer
Copy link

emkookmer commented Aug 3, 2020

Hi,

The following record isn't processed

RRSIG	SOA 8 2 86400 (
		20200416000000 20200326000000 25078 3mtape.nl.
		sLGSfcmcvXQ4EGMXrUFFE1JO17AxhspZY8xXiCLEDN95
		S90KgnDUKzzIUTjjGao0G7XpzhoCgsXyAyJeTgTwa4v5
		ICV8xCF1dpUMb7aHRw2l0MA2dDZ30w33QTqU7TEbETpy
		NqTbK9qaabsTTXSIGg2ChKV8MwiGm/TyjnARjVo= )

This is due to that the iterator isn't at the beginning on the line below :

$this->currentResourceRecord->setRdata($this->extractRdata($iterator));

The solution would be to implement it as follows

if ($this->isType($iterator)) {
    while ($iterator->key() > 1 && $this->isType($iterator)) {
        $iterator->prev();
    }
    $iterator->next();

    $this->currentResourceRecord->setRdata($this->extractRdata($iterator));
    $this->populateWithLastStated();

    return;
}
@samuelwilliams
Copy link
Contributor

Hi @emkookmer

Thanks for the issue. What is the error message you are getting? Can you provide a stack trace. I suspect it has something to do with the domain validation - but I would appreciate your stack trace.

Thanks!

@samuelwilliams
Copy link
Contributor

Disregard - I had another look at it - Your fix looks good

samuelwilliams added a commit that referenced this issue Oct 5, 2020
samuelwilliams added a commit that referenced this issue Oct 5, 2020
* Added fix for Issue #75
@samuelwilliams samuelwilliams added this to the Version 4 milestone Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants