Parser: TXT record with number as value throws exception

[lorenzbausch]

Reproduce:

<?php

require_once 'vendor/autoload.php';

$zone = Badcow\DNS\Parser\Parser::parse('foo.tld.', 'foo.	14400	IN	TXT	3600');

stack trace:

PHP Fatal error:  Uncaught TypeError: Argument 1 passed to Badcow\DNS\Classes::isValid() must be of the type string, null given, called in /path/to/project/vendor/badcow/dns/lib/Parser/Parser.php on line 365 and defined in /path/to/project/vendor/badcow/dns/lib/Classes.php:53
Stack trace:
#0 /path/to/project/vendor/badcow/dns/lib/Parser/Parser.php(365): Badcow\DNS\Classes::isValid(NULL)
#1 /path/to/project/vendor/badcow/dns/lib/Parser/Parser.php(415): Badcow\DNS\Parser\Parser->isClass(Object(Badcow\DNS\Parser\ResourceRecordIterator), 'TTL')
#2 /path/to/project/vendor/badcow/dns/lib/Parser/Parser.php(342): Badcow\DNS\Parser\Parser->isTTL(Object(Badcow\DNS\Parser\ResourceRecordIterator))
#3 /path/to/project/vendor/badcow/dns/lib/Parser/Parser.php(170): Badcow\DNS\Parser\Parser->isResourceName(Object(Badcow\DNS\Parser\ResourceRecordIterator))
#4 /path/to/project/vendor/badcow/dns/lib/Parser/P in /path/to/project/vendor/badcow/dns/lib/Classes.php on line 53

(Might be related to #88 ?)

Thank you for maintaining this library, it's a real 💎!

[samuelwilliams]

@lorenzbausch I think this is a different issue to #88, but they still are related. These are very niche edge case behaviours because I have never come across a TXT string that wasn't encapsulated in quotes.

[samuelwilliams]

Fixed with PR #93

[lorenzbausch]

@samuelwilliams thank you for fixing this 💪 In fact I encountered this issue when parsing zone files with user supplied content.