Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix store and model task objects to update dueTime #2

Closed
BaderSZ opened this issue Jun 18, 2022 · 3 comments
Closed

Fix store and model task objects to update dueTime #2

BaderSZ opened this issue Jun 18, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@BaderSZ
Copy link
Owner

BaderSZ commented Jun 18, 2022

I am yet to confirm if this is an issue on my end/implementation, CalendarJS or something else. for now, see issue #1

@BaderSZ
Copy link
Owner Author

BaderSZ commented Jun 18, 2022

Pasting unit test error here:

 FAIL  tests/javascript/unit/views/AppSidebar.spec.js
  AppSidebar.vue
    ✕ Returns the correct value for the new dates (41 ms)

  ● AppSidebar.vue › Returns the correct value for the new dates

    expect(received).toBe(expected) // Object.is equality

    Expected: 1546354860000
    Received: 1546346040000

      48 |              wrapper.vm.setDueDate({ task: wrapper.vm.task, value: newDueDate })
      49 |              actual = wrapper.vm.newDueDate
    > 50 |              expect(actual.getTime()).toBe(newDueDate.getTime())
         |                                       ^
      51 |      })
      52 | })
      53 |

      at Object.toBe (tests/javascript/unit/views/AppSidebar.spec.js:50:28)

 

@BaderSZ BaderSZ added the bug Something isn't working label Jun 18, 2022
@BaderSZ
Copy link
Owner Author

BaderSZ commented Jun 18, 2022

Well the problem wasn't dueTime , but rather, the property wasn't updated at all due to an incomplete store/tasks.js.

@BaderSZ BaderSZ changed the title Fix precision in ToDoComponent.dueTime Fix store and model task objects to update dueTime Jun 18, 2022
@BaderSZ
Copy link
Owner Author

BaderSZ commented Jun 19, 2022

Should be fixed in 7e741b3 and 9ccb9a2

@BaderSZ BaderSZ closed this as completed Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant