Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

script: for loop treasury council members and add them as owner #450

Merged
merged 1 commit into from May 17, 2022
Merged

script: for loop treasury council members and add them as owner #450

merged 1 commit into from May 17, 2022

Conversation

gosuto-inzasheru
Copy link
Collaborator

script to solve #442

petrovska-petro
petrovska-petro approved these changes May 16, 2022
View reviewed changes
Copy link
Collaborator

@petrovska-petro petrovska-petro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script looks good and changes threshold to 5

Confirming at my end is the right address for my signer

would be great to get same confirmation for all the addr additions on this PR as there is no other way to confirm address veracity

@dapp-whisperer
Copy link
Contributor

confirmed dapp address

sajanrajdev
sajanrajdev approved these changes May 16, 2022
View reviewed changes
Copy link
Collaborator

@sajanrajdev sajanrajdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iterates through list of signers' addresses and adds them to the multisig if not already added. Also, sets the threshold to 5.

LGTM

Also, confimed Saj's address.

Hal69k
Hal69k reviewed May 16, 2022
View reviewed changes
Copy link

@Hal69k Hal69k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming 1500 address is correct

@shuklaayush
Copy link
Contributor

Confirming ayush's address

@jonto-badger
Copy link

confirming jonto address

@MrrPo
Copy link

MrrPo commented May 17, 2022

Confirming Po's address is correct

@gosuto-inzasheru gosuto-inzasheru merged commit d22d33e into main May 17, 2022
@gosuto-inzasheru gosuto-inzasheru deleted the issue/442 branch May 17, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hal69k Hal69k Hal69k left review comments

@sajanrajdev sajanrajdev sajanrajdev approved these changes

@petrovska-petro petrovska-petro petrovska-petro approved these changes

@jalbrekt85 jalbrekt85 Awaiting requested review from jalbrekt85

@dapp-whisperer dapp-whisperer Awaiting requested review from dapp-whisperer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@gosuto-inzasheru @dapp-whisperer @shuklaayush @jonto-badger @MrrPo @sajanrajdev @petrovska-petro @Hal69k