feat: keep gross and net revenue separated, separate level gauges #6

gosuto-inzasheru · 2023-05-16T11:08:32Z

does not mix gross and net revenue: separate metric, separate column
same for gauges. different columns for the different level of gauges (split gauge column in case of multiple gauges #3)

petrovska-petro

i like the drilling approach you added for the diff gauges and diff between net vs gross

good addition ✅

gosuto-inzasheru added 7 commits May 16, 2023 17:30

feat: separate revenue into gross and net

3bac191

feat: separate gauge column into levels

f9e1e4e

style: replace zeroes with nan or empty string

2899bc2

fix: cannot pct_format strings

c42a518

feat: format np.nan to empty cells

e4441c8

fix: proper checking for np.nan

27ffc32

docs: add python restriction

c26910f

gosuto-inzasheru requested a review from petrovska-petro May 16, 2023 11:08

gosuto-inzasheru changed the title ~~keep gross and n~~ feat: keep gross and net revenue separated, separate level gauges May 16, 2023

petrovska-petro approved these changes May 16, 2023

View reviewed changes

petrovska-petro merged commit d193181 into feat/reduce-our-vote May 16, 2023

petrovska-petro deleted the feat/gross_net_revenue branch May 16, 2023 19:55

gosuto-inzasheru mentioned this pull request May 18, 2023

split gauge column in case of multiple gauges #3

Closed

Provide feedback