Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for rendering Markdown as HTML #228

Closed
Badgerati opened this issue Apr 15, 2019 · 5 comments · Fixed by #340
Closed

Support for rendering Markdown as HTML #228

Badgerati opened this issue Apr 15, 2019 · 5 comments · Fixed by #340
Assignees
Milestone

Comments

@Badgerati
Copy link
Owner

This is to add in support for rendering Markdown files as HTML content - using the PowerShell function: ConvertFrom-Markdown.

There should be:

  • A new markdown function, like html, that takes raw data or a file path and converts the markdown to html. At the end of the function, it should be similar to the html function when render the content back as html.
  • Internal support for markdown as a view engine. Currently there is pode, html, and anything else for custom/third-party - this will add inbuilt support for a new markdown type, which will get markdown files and convert them to html.
  • Could have possible support on static content; so if it sees a .md/.markdown file, it automatically converts it to html 🤔
  • The markdown mimetype will need adding to the Get-PodeContentType function.
@Badgerati Badgerati added this to the 0.29.0 milestone Apr 15, 2019
Badgerati added a commit that referenced this issue Apr 17, 2019
@Badgerati Badgerati self-assigned this Apr 17, 2019
@Badgerati
Copy link
Owner Author

On-hold, pending PowerShell/PowerShell#9390 (comment) (issue with running the ConvertFrom-Markdown command in a new runspace)

@Badgerati
Copy link
Owner Author

PowerShell/PowerShell#9390 (comment) has been fixed, just hoping it gets into v6.2.1

@Badgerati Badgerati modified the milestones: 0.29.0, 0.30.0 May 8, 2019
@Badgerati
Copy link
Owner Author

Looks like v6.2.1 is released (https://github.com/PowerShell/PowerShell/releases/tag/v6.2.1), which also comes with the Markdown fix!

Once it's released as an installer/container I'll continue with this.

@Badgerati
Copy link
Owner Author

It would appear that v6.2.1 actually contained security fixes, and not what's on the release notes for the tag.

Guess this is waiting till v6.2.2.

@Badgerati
Copy link
Owner Author

Can finish this off now, with rendering Markdown as HTML only been supported in PS7+.

@Badgerati Badgerati modified the milestones: backlog, 1.0.0 Aug 21, 2019
Badgerati added a commit that referenced this issue Aug 22, 2019
Badgerati added a commit that referenced this issue Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant