Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending a payload, then an empty payload on an KeepAlive connection still has the old payload #738

Closed
Badgerati opened this issue May 2, 2021 · 0 comments · Fixed by #740
Assignees
Labels
Milestone

Comments

@Badgerati
Copy link
Owner

Describe the Bug

If you make two requests to an empty, using KeepAlive, and the first request has a payload but the second doesn't; the second request will retain the payload of the first.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Make a request with KeepAlive with a payload
  2. Make the same request, but no payload

Expected Behavior

The second request should not have anything in $WebEvent.Data, but it does.

Platform

  • OS: Windows
  • Versions:
    • Pode: v2.2.3
    • PowerShell: v7

Additional Context

This was found while documenting Pode.Web. The error is in PodeHttpRequest.cs line 48. The body will only be reset if there is a RawBody, this should return string.Empty if there is no RawBody available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant