Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No validation on reset password page #89

Closed
medamineziraoui opened this issue Mar 8, 2021 · 3 comments
Closed

No validation on reset password page #89

medamineziraoui opened this issue Mar 8, 2021 · 3 comments

Comments

@medamineziraoui
Copy link
Collaborator

medamineziraoui commented Mar 8, 2021

When we try to populate the reset password page, if we leave the inputs empty or not identical password we don t get any error message

how to get to the page:
http://localhost:3000/account/amine+6@bearstudio.fr/password/bvoTW85Te2NCgyC4tPK11gONcH8qCF

@medamineziraoui medamineziraoui changed the title Not validation on reset password page No validation on reset password page Mar 8, 2021
@Gregoire-Bearstudio
Copy link
Collaborator

Gregoire-Bearstudio commented Mar 17, 2021

We encountered a few problems :

  • We can put the same current password
  • The same password reset link works several times
  • There is no form validation if we put less than the minimum number of characters in the password field
  • We can modify the email in the link to edit someone else's password. We can't change the password, but we should be redirected to the login page in that case
  • We send the password and the password confirmation. We only one of these, since the validation on the front-end side (one of the information is redundant, see image on "Requested payload")
    image

@Gregoire-Bearstudio
Copy link
Collaborator

The previous problems are still unchanged, and need to be corrected (maybe another time, but we have to keep these in mind)

@medamineziraoui
Copy link
Collaborator Author

Close this issue, feedback are converted to another one
#166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants