Siva Reddy | Adding GHA to validate PR and publish npm package #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohan-13
reviewed
Jun 1, 2023
| - name: yarn test | ||
| run: yarn test | ||
| - run: yarn ci | ||
| - name: Publish the package |
There was a problem hiding this comment.
Actually this step should only run when it is a tag push. But okay for now. Anyways once a version is pushed NPM will not allow you to override. @sivareddyp Can you please create a JIRA card to handle this later?
There was a problem hiding this comment.
Created a Jira card to handle this - https://bahmni.atlassian.net/browse/BS-130
mohan-13
approved these changes
Jun 2, 2023
mohan-13
approved these changes
Jun 2, 2023
mohan-13
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHA for validating PR and publishing package for form controls