Phani | A-1206828243895868 | Remove debouncing and add API cancellation for Appointment Patient Search #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinithishg
reviewed
Mar 25, 2024
| @@ -59,6 +65,11 @@ export const PatientSearch = (props) => { | |||
| label: intl.formatMessage({id: 'DROPDOWN_TYPE_TO_SEARCH_MESSAGE', defaultMessage: 'Type to search'}), | |||
| disabled: true | |||
| }]); | |||
| } else{ | |||
| setItems([{ | |||
| label: intl.formatMessage({id: 'DROPDOWN_LOADING_MESSAGE', defaultMessage: 'Loading...'}), | |||
There was a problem hiding this comment.
Can we refactor this if possible ?
separating this into a constants and set the value, we can also add the disabled key also incase if this disabled value is not changing in so many places.
srinithishg
approved these changes
Mar 25, 2024
Arjun-Go
pushed a commit
that referenced
this pull request
May 22, 2024
…on for Appointment Patient Search (#323) * Phani : Add logic to Cancel API calls in-flight * Phani : Fix tests * Phani : Remove debounce related code * Phani : Add method to create disabled dropdown options
SanoferSameera
pushed a commit
that referenced
this pull request
Jun 11, 2024
* Bindu |Change the update error message (#309) * Phani | A-1206828243895868 | Remove debouncing and add API cancellation for Appointment Patient Search (#323) * Phani : Add logic to Cancel API calls in-flight * Phani : Fix tests * Phani : Remove debounce related code * Phani : Add method to create disabled dropdown options * A-1207131329891848 | Filtering on Awaiting Appointments should query the backend (#330) * fix. awaiting appointments search post API update * add. filter for awaiting appointments for bulk waitlists * fix. existing tests after appointments earch API update * add. test for checking appointments earch getting called when a filter is selected * fix. awaiting appointment list after applying filter (#331) * BAH-3860 | Fix build failure * BAH-3860 | remove test --------- Co-authored-by: Himabindu T <tbindu@thoughtworks.com> Co-authored-by: Phanindra-tw <v.tadikonda@thoughtworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.