Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: output dir is dir #47

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SiyaoIsHiding
Copy link

In this code snippet:

let OutputDir = getRunnerInput('output_dir', 'built', getRunnerPath);
let OutputDirIsDir = false
try {
    OutputDirIsDir = fs.lstatSync(OutputDir).isDirectory();
} catch { }
if (!OutputDirIsDir) {
    OutputDir += OutputDir.endsWith("/") ? "" : "/"
    CreateOutputDirectory(OutputDir);
}

The current logic is - if the output directory is not a directory, then ensure it ends with a slash.
The logic should be - if the output directory is a directory, then ensure it ends with a slash.

@SiyaoIsHiding
Copy link
Author

@BaileyJM02 , just in case u didn't receive the notification on the pull request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant