Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP-353 CSPv5 permission granting #358

Merged
merged 21 commits into from Jul 14, 2023
Merged

BIP-353 CSPv5 permission granting #358

merged 21 commits into from Jul 14, 2023

Conversation

solarcurvey
Copy link
Collaborator

No description provided.

@BalancerMaxis BalancerMaxis deleted a comment from github-actions bot Jul 12, 2023
@BalancerMaxis BalancerMaxis deleted a comment from github-actions bot Jul 12, 2023
@BalancerMaxis BalancerMaxis deleted a comment from github-actions bot Jul 12, 2023
@Tritium-VLK
Copy link
Member

@solarcurvey If you could give this a onceover... Can't assign you as the reviewer cuz you created the BIP.

@github-actions
Copy link
Contributor

BIP validation results for file BIPs/2023-W28/BIP-353/arbitrum.json:
Commit: f51ad1984b0815896dc52828476782392da6556f

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
+-------------------------------+--------+

BIP validation results for file BIPs/2023-W28/BIP-353/avalanche.json:
Commit: f51ad1984b0815896dc52828476782392da6556f

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
+-------------------------------+--------+

BIP validation results for file BIPs/2023-W28/BIP-353/gnosis.json:
Commit: f51ad1984b0815896dc52828476782392da6556f

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
+-------------------------------+--------+

BIP validation results for file BIPs/2023-W28/BIP-353/mainnet.json:
Commit: f51ad1984b0815896dc52828476782392da6556f

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
+-------------------------------+--------+

BIP validation results for file BIPs/2023-W28/BIP-353/optimism.json:
Commit: f51ad1984b0815896dc52828476782392da6556f

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
+-------------------------------+--------+

BIP validation results for file BIPs/2023-W28/BIP-353/polygon.json:
Commit: f51ad1984b0815896dc52828476782392da6556f

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
+-------------------------------+--------+

BIP validation results for file BIPs/2023-W28/BIP-353/zkevm.json:
Commit: f51ad1984b0815896dc52828476782392da6556f

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
+-------------------------------+--------+

@github-actions
Copy link
Contributor

BIP validation results for file BIPs/2023-W28/BIP-353/arbitrum.json:
Commit: 9ea20ac5a44ab95ef504c79a9a106726c0e990bd

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
+-------------------------------+--------+

BIP validation results for file BIPs/2023-W28/BIP-353/avalanche.json:
Commit: 9ea20ac5a44ab95ef504c79a9a106726c0e990bd

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
+-------------------------------+--------+

BIP validation results for file BIPs/2023-W28/BIP-353/gnosis.json:
Commit: 9ea20ac5a44ab95ef504c79a9a106726c0e990bd

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
+-------------------------------+--------+

BIP validation results for file BIPs/2023-W28/BIP-353/mainnet.json:
Commit: 9ea20ac5a44ab95ef504c79a9a106726c0e990bd

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
+-------------------------------+--------+

BIP validation results for file BIPs/2023-W28/BIP-353/optimism.json:
Commit: 9ea20ac5a44ab95ef504c79a9a106726c0e990bd

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
+-------------------------------+--------+

BIP validation results for file BIPs/2023-W28/BIP-353/polygon.json:
Commit: 9ea20ac5a44ab95ef504c79a9a106726c0e990bd

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
+-------------------------------+--------+

BIP validation results for file BIPs/2023-W28/BIP-353/zkevm.json:
Commit: 9ea20ac5a44ab95ef504c79a9a106726c0e990bd

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
+-------------------------------+--------+

@solarcurvey
Copy link
Collaborator Author

reviewed a couple of the jsons and all looks correct

@Tritium-VLK Tritium-VLK merged commit 8e916d0 into main Jul 14, 2023
3 checks passed
@Tritium-VLK Tritium-VLK deleted the bip-353 branch July 27, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants