Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIP-418-USDF-USDC #485

Merged
merged 6 commits into from Sep 17, 2023
Merged

BIP-418-USDF-USDC #485

merged 6 commits into from Sep 17, 2023

Conversation

Zen-Maxi
Copy link
Collaborator

@Zen-Maxi Zen-Maxi commented Aug 24, 2023 •
edited by Xeonus

@github-actions
Copy link
Contributor

BIP validation results for file BIPs/2023-W34/BIP-412.json:
Commit: a9f74f551de4aa7ae4e1026397361529df3cb303

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

@github-actions
Copy link
Contributor

File name: BIPs/2023-W34/BIP-412.json
COMMIT: a9f74f551de4aa7ae4e1026397361529df3cb303
CHAIN(S): arbitrum

+-----------------------+---------------------------------------------------------------------+--------------------------+--------------------------------------------+-------------------------------------------------------------+-------------------------------------------------+---------+------------+
| function              | pool_id_and_address                                                 | symbol_and_info          | gauge_address_and_info                     | tokens                                                      | rate_providers                                  | bip     |   tx_index |
+=======================+=====================================================================+==========================+============================================+=============================================================+=================================================+=========+============+
| GaugeAdderV4/addGauge | 0xa7952cd7ea8effbd81c2b4de72a1e5b9bd1b3e2a0000000000000000000004a1  | USDF/4pool               | 0xd211A8401c9aFeb7c36591245474Ca628F559aB8 | "4POOL-BPT(0x423A1323c871aBC9d89EB06855bF5347048Fc4A5)",    | "0x0000000000000000000000000000000000000000",   | BIP-412 |          0 |
|                       | pool_address: 0xa7952cd7Ea8Effbd81c2B4De72A1E5b9Bd1b3E2a            | fee: 0.05, a-factor: 200 |  Style: L0 sidechain, cap: 100.0%          |   "USDF/4pool(0xa7952cd7Ea8Effbd81c2B4De72A1E5b9Bd1b3E2a)", |   "0x0000000000000000000000000000000000000000", |         |            |
|                       |                                                                     |                          |                                            |   "USDF(0xae48b7C8e096896E32D53F10d0Bf89f82ec7b987)"        |   "0x0000000000000000000000000000000000000000"  |         |            |
+-----------------------+---------------------------------------------------------------------+--------------------------+--------------------------------------------+-------------------------------------------------------------+-------------------------------------------------+---------+------------+

@solarcurvey
Copy link
Collaborator

solarcurvey commented Aug 28, 2023 •
edited

note USDF needs a rate provider as its value slowly increases over time from yield earned.

this is the one made by them under review by integrations team: https://arbiscan.io/address/0xd438f19b1dd47ebecc5f904d8fd44583cbfb7c85#readContract

vote will tentatively begin this thursday. pool will need to be remade. json moved into the next week folder

@Zen-Maxi Zen-Maxi changed the title BIP-412-USDF-4pool BIP-418-USDF-USDC Sep 2, 2023
@Zen-Maxi
BIP-418
ddadcbb 
Originally BIP-412 to add USDF/4pool gauge. Now will be new pool USDF / USDC with new gauge. Transaction simulation here: https://dashboard.tenderly.co/public/safe/safe-apps/simulator/39fe9b86-aec1-4fde-9146-df7d67841836
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

BIP validation results for file BIPs/2023-W35/BIP-418.json:
Commit: ddadcbb792639e2a3e54087eb96b72b2bfb02d52

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

File name: BIPs/2023-W35/BIP-418.json
COMMIT: ddadcbb792639e2a3e54087eb96b72b2bfb02d52
CHAIN(S): arbitrum

+-----------------------+---------------------------------------------------------------------+--------------------------+--------------------------------------------+----------------------------------------------------------+-------------------------------------------------+---------+------------+
| function              | pool_id_and_address                                                 | symbol_and_info          | gauge_address_and_info                     | tokens                                                   | rate_providers                                  | bip     |   tx_index |
+=======================+=====================================================================+==========================+============================================+==========================================================+=================================================+=========+============+
| GaugeAdderV4/addGauge | 0x6b9f3f6b9054a45702d3f2c6e3d32a60204934cb0000000000000000000004a7  | USDF/USDC                | 0x25DDcad849de576c2A6c124984cE59e62739156D | "USDF/USDC(0x6B9f3f6b9054A45702D3F2C6e3D32A60204934cb)", | "0x0000000000000000000000000000000000000000",   | BIP-418 |          0 |
|                       | pool_address: 0x6B9f3f6b9054A45702D3F2C6e3D32A60204934cb            | fee: 0.05, a-factor: 200 |  Style: L0 sidechain, cap: 100.0%          |   "USDF(0xae48b7C8e096896E32D53F10d0Bf89f82ec7b987)",    |   "0xD438f19b1Dd47EbECc5f904d8Fd44583CbFB7c85", |         |            |
|                       |                                                                     |                          |                                            |   "USDC(0xaf88d065e77c8cC2239327C5EDb3A432268e5831)"     |   "0x0000000000000000000000000000000000000000"  |         |            |
+-----------------------+---------------------------------------------------------------------+--------------------------+--------------------------------------------+----------------------------------------------------------+-------------------------------------------------+---------+------------+

@github-actions
Copy link
Contributor

BIP validation results for file BIPs/2023-W37/BIP-418.json:
Commit: 8b24b633902a95854e8a5fdc0c827a59921f9f28

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

@github-actions
Copy link
Contributor

File name: BIPs/2023-W37/BIP-418.json
COMMIT: 8b24b633902a95854e8a5fdc0c827a59921f9f28
CHAIN(S): arbitrum

+-----------------------+---------------------------------------------------------------------+--------------------------+--------------------------------------------+----------------------------------------------------------+-------------------------------------------------+---------+------------+
| function              | pool_id_and_address                                                 | symbol_and_info          | gauge_address_and_info                     | tokens                                                   | rate_providers                                  | bip     |   tx_index |
+=======================+=====================================================================+==========================+============================================+==========================================================+=================================================+=========+============+
| GaugeAdderV4/addGauge | 0x6b9f3f6b9054a45702d3f2c6e3d32a60204934cb0000000000000000000004a7  | USDF/USDC                | 0x25DDcad849de576c2A6c124984cE59e62739156D | "USDF/USDC(0x6B9f3f6b9054A45702D3F2C6e3D32A60204934cb)", | "0x0000000000000000000000000000000000000000",   | BIP-418 |          0 |
|                       | pool_address: 0x6B9f3f6b9054A45702D3F2C6e3D32A60204934cb            | fee: 0.05, a-factor: 200 |  Style: L0 sidechain, cap: 100.0%          |   "USDF(0xae48b7C8e096896E32D53F10d0Bf89f82ec7b987)",    |   "0xD438f19b1Dd47EbECc5f904d8Fd44583CbFB7c85", |         |            |
|                       |                                                                     |                          |                                            |   "USDC(0xaf88d065e77c8cC2239327C5EDb3A432268e5831)"     |   "0x0000000000000000000000000000000000000000"  |         |            |
+-----------------------+---------------------------------------------------------------------+--------------------------+--------------------------------------------+----------------------------------------------------------+-------------------------------------------------+---------+------------+

@Tritium-VLK Tritium-VLK merged commit f1be0b4 into main Sep 17, 2023
@Tritium-VLK Tritium-VLK deleted the BIP-412 branch September 30, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tritium-VLK Tritium-VLK Tritium-VLK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zen-Maxi @solarcurvey @Tritium-VLK