Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIP-441: Enable qETH/WETH Gauge 2% Cap [Ethereum] #529

Merged
merged 2 commits into from Sep 30, 2023
Merged

BIP-441: Enable qETH/WETH Gauge 2% Cap [Ethereum] #529

merged 2 commits into from Sep 30, 2023

Conversation

Xeonus
Copy link
Collaborator

@Xeonus Xeonus commented Sep 27, 2023

@github-actions
Copy link
Contributor

BIP validation results for file BIPs/2023-W39/BIP-441.json:
Commit: 651d3191ba66e6904610d228212eaa3e2fa37a84

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

@github-actions
Copy link
Contributor

File name: BIPs/2023-W39/BIP-441.json
COMMIT: 651d3191ba66e6904610d228212eaa3e2fa37a84
CHAIN(S): mainnet

+-----------------------+---------------------------------------------------------------------+--------------------------+--------------------------------------------+----------------------------------------------------------+-------------------------------------------------+---------+------------+
| function              | pool_id_and_address                                                 | symbol_and_info          | gauge_address_and_info                     | tokens                                                   | rate_providers                                  | bip     |   tx_index |
+=======================+=====================================================================+==========================+============================================+==========================================================+=================================================+=========+============+
| GaugeAdderV4/addGauge | 0x40c806394d03d350420d13cd7d1de1c806f349560000000000000000000005f5  | qETH/WETH                | 0x6A58e7C904eCF991A3183d28FC73bE90732B7a30 | "qETH/WETH(0x40C806394d03d350420d13CD7d1DE1C806f34956)", | "0x0000000000000000000000000000000000000000",   | BIP-441 |          0 |
|                       | pool_address: 0x40C806394d03d350420d13CD7d1DE1C806f34956            | fee: 0.04, a-factor: 100 |  Style: mainnet, cap: 2.0%                 |   "qETH(0x93ef1Ea305D11A9b2a3EbB9bB4FCc34695292E7d)",    |   "0xA6aeD7922366611953546014A3f9e93f058756a2", |         |            |
|                       |                                                                     |                          |                                            |   "WETH(0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2)"     |   "0x0000000000000000000000000000000000000000"  |         |            |
+-----------------------+---------------------------------------------------------------------+--------------------------+--------------------------------------------+----------------------------------------------------------+-------------------------------------------------+---------+------------+

Tritium-VLK
Tritium-VLK approved these changes Sep 30, 2023
View reviewed changes
Copy link
Member

@Tritium-VLK Tritium-VLK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/threerocks-defi/code-review/blob/main/rate-providers/QueenRateProvider.md

BIPs/2023-W39/BIP-441.report.txt
| function | pool_id_and_address | symbol_and_info | gauge_address_and_info | tokens | rate_providers | bip | tx_index |
+=======================+=====================================================================+==========================+============================================+==========================================================+=================================================+=========+============+
| GaugeAdderV4/addGauge | 0x40c806394d03d350420d13cd7d1de1c806f349560000000000000000000005f5 | qETH/WETH | 0x6A58e7C904eCF991A3183d28FC73bE90732B7a30 | "qETH/WETH(0x40C806394d03d350420d13CD7d1DE1C806f34956)", | "0x0000000000000000000000000000000000000000", | BIP-441 | 0 |
| | pool_address: 0x40C806394d03d350420d13CD7d1DE1C806f34956 | fee: 0.04, a-factor: 100 | Style: mainnet, cap: 2.0% | "qETH(0x93ef1Ea305D11A9b2a3EbB9bB4FCc34695292E7d)", | "0xA6aeD7922366611953546014A3f9e93f058756a2", | | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/threerocks-defi/code-review/blob/main/rate-providers/QueenRateProvider.md

@Tritium-VLK Tritium-VLK merged commit d01c60b into main Sep 30, 2023
@Tritium-VLK Tritium-VLK deleted the BIP-441-qETH-ETH-gauge-Mainnet branch September 30, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tritium-VLK Tritium-VLK Tritium-VLK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Xeonus @Tritium-VLK