Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIP-460: Enable rETH/WETH gauge [zkEVM] #585

Merged
merged 4 commits into from Oct 25, 2023
Merged

BIP-460: Enable rETH/WETH gauge [zkEVM] #585

merged 4 commits into from Oct 25, 2023

Conversation

gosuto-inzasheru
Copy link
Member

dd

0x42a3290a65CA16Adaf161c6FfAfDBE0913A169F4.getRecipient().lp_token().name() == "Gyroscope ECLP wETH/rETH"
0x42a3290a65CA16Adaf161c6FfAfDBE0913A169F4.getRelativeWeightCap() / 1e18 == 1.

closes #584

@github-actions
Copy link
Contributor

BIP validation results for file BIPs/00proposed/bip-xxx-enable-reth-weth-gauge-zkevm.json:
Commit: 0a566b8a947745752d11bf88854cfad256f430e3

+-------------------------------+--------------------------------------------------------------------------------------------+
|           Validator           |                                           Result                                           |
+-------------------------------+--------------------------------------------------------------------------------------------+
|     validate_contains_msig    |                                             OK                                             |
| validate_msig_in_address_book |                                             OK                                             |
|    validate_chain_specified   |                                             OK                                             |
|     validate_file_has_bip     | No BIP number found in file path BIPs/00proposed/bip-xxx-enable-reth-weth-gauge-zkevm.json |
|  validate_path_has_weekly_dir | File BIPs/00proposed/bip-xxx-enable-reth-weth-gauge-zkevm.json has has no YYYY-W## in path |
+-------------------------------+--------------------------------------------------------------------------------------------+

@github-actions
Copy link
Contributor

File name: BIPs/00proposed/bip-xxx-enable-reth-weth-gauge-zkevm.json
COMMIT: 0a566b8a947745752d11bf88854cfad256f430e3
CHAIN(S): zkevm

+-----------------------+---------------------------------------------------------------------+--------------------------+--------------------------------------------+------------------------------------------------------+------------------+-------+------------+
| function              | pool_id_and_address                                                 | symbol_and_info          | gauge_address_and_info                     | tokens                                               | rate_providers   | bip   |   tx_index |
+=======================+=====================================================================+==========================+============================================+======================================================+==================+=======+============+
| GaugeAdderV4/addGauge | 0xb1557cfea06de5a1601a7f0ccf3b515ef431a50d000200000000000000000059  | ECLP-wETH-rETH           | 0x42a3290a65CA16Adaf161c6FfAfDBE0913A169F4 | "WETH(0x4F9A0e7FD2Bf6067db6994CF12E4495Df938E6e9)",  |                  | N/A   |          0 |
|                       | pool_address: 0xb1557CFEA06De5a1601a7F0cCF3b515EF431A50d            | fee: 0.01, a-factor: N/A |  Style: L0 sidechain, cap: 100.0%          |   "rETH(0xb23C20EFcE6e24Acca0Cef9B7B7aA196b84EC942)" |                  |       |            |
+-----------------------+---------------------------------------------------------------------+--------------------------+--------------------------------------------+------------------------------------------------------+------------------+-------+------------+

@Xeonus Xeonus changed the title BIP-XXX: Enable rETH/WETH gauge [zkEVM] BIP-460: Enable rETH/WETH gauge [zkEVM] Oct 25, 2023
@github-actions
Copy link
Contributor

BIP validation results for file BIPs/2023-W43/BIP-460.json:
Commit: a11173f3e5060cc37b7b3e298fffd4511aca205f

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

@github-actions
Copy link
Contributor

File name: BIPs/2023-W43/BIP-460.json
COMMIT: a11173f3e5060cc37b7b3e298fffd4511aca205f
CHAIN(S): zkevm

+-----------------------+---------------------------------------------------------------------+--------------------------+--------------------------------------------+------------------------------------------------------+------------------+---------+------------+
| function              | pool_id_and_address                                                 | symbol_and_info          | gauge_address_and_info                     | tokens                                               | rate_providers   | bip     |   tx_index |
+=======================+=====================================================================+==========================+============================================+======================================================+==================+=========+============+
| GaugeAdderV4/addGauge | 0xb1557cfea06de5a1601a7f0ccf3b515ef431a50d000200000000000000000059  | ECLP-wETH-rETH           | 0x42a3290a65CA16Adaf161c6FfAfDBE0913A169F4 | "WETH(0x4F9A0e7FD2Bf6067db6994CF12E4495Df938E6e9)",  |                  | BIP-460 |          0 |
|                       | pool_address: 0xb1557CFEA06De5a1601a7F0cCF3b515EF431A50d            | fee: 0.01, a-factor: N/A |  Style: L0 sidechain, cap: 100.0%          |   "rETH(0xb23C20EFcE6e24Acca0Cef9B7B7aA196b84EC942)" |                  |         |            |
+-----------------------+---------------------------------------------------------------------+--------------------------+--------------------------------------------+------------------------------------------------------+------------------+---------+------------+

@Tritium-VLK Tritium-VLK merged commit ee494e6 into main Oct 25, 2023
@Tritium-VLK Tritium-VLK deleted the issue/584 branch November 27, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tritium-VLK Tritium-VLK Tritium-VLK approved these changes

@Zen-Maxi Zen-Maxi Awaiting requested review from Zen-Maxi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

https://forum.balancer.fi/t/bip-xxx-enable-reth-weth-gauge-zkevm/5276
3 participants
@gosuto-inzasheru @Tritium-VLK @Xeonus