Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIP-475: Kill ROOT/WETH Gauge [Ethereum] #612

Merged
merged 2 commits into from Nov 13, 2023
Merged

BIP-475: Kill ROOT/WETH Gauge [Ethereum] #612

merged 2 commits into from Nov 13, 2023

Conversation

Xeonus
Copy link
Collaborator

@Xeonus Xeonus commented Nov 8, 2023

@Xeonus
BIP-475: Kill ROOT/WETH Gauge [Ethereum]
3986008 
- kill ROOT/WETH gauge on mainnet
- Tenderly-sim: https://dashboard.tenderly.co/public/safe/safe-apps/simulator/93cd1333-2070-4d5e-b533-cec69dab9491

- remove core pool designation from config
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

BIP validation results for file BIPs/2023-W45/BIP-475.json:
Commit: 39860087f9e887d6800624d76675429d55d216b9

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

File name: BIPs/2023-W45/BIP-475.json
COMMIT: 39860087f9e887d6800624d76675429d55d216b9
CHAIN(S): mainnet

+--------------------------+--------------------------------------------------------------------+---------------+-----+--------------------------------------------+-------+-------+---------+---------+------------+----------------------------------------------------------------------------------------------------------+
| function                 | pool_id                                                            | symbol        | a   | gauge_address                              | fee   | cap   | style   | bip     |   tx_index | tokens                                                                                                   |
+==========================+====================================================================+===============+=====+============================================+=======+=======+=========+=========+============+==========================================================================================================+
| AAEntrypoint/killGauge() | 0x02ca8086498552c071451724d3a34caa3922b65a000200000000000000000613 | 80ROOT-20WETH | N/A | 0xd639e7fAe7a8d0233d416bfd5dA2ae4f917D2E77 | 2.0%  | 2.0%  | mainnet | BIP-475 |          0 | ['ROOT(0x8d2658E0F52dF7875A7b3e58FC12F82F5e34dd61)', 'WETH(0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2)'] |
+--------------------------+--------------------------------------------------------------------+---------------+-----+--------------------------------------------+-------+-------+---------+---------+------------+----------------------------------------------------------------------------------------------------------+

SHAKOTN
SHAKOTN approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@SHAKOTN SHAKOTN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Destination looks correct; also removed ROOT pool from core pools config. LGTM

@Tritium-VLK Tritium-VLK merged commit 071c3e1 into main Nov 13, 2023
@Tritium-VLK Tritium-VLK deleted the BIP-475-kill-root-gauge-mainnet branch November 27, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SHAKOTN SHAKOTN SHAKOTN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Xeonus @SHAKOTN @Tritium-VLK