Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIP478: Enable 80mevETH/20FOLD Gauge [Ethereum] #615

Merged
merged 5 commits into from Nov 13, 2023
Merged

BIP478: Enable 80mevETH/20FOLD Gauge [Ethereum] #615

merged 5 commits into from Nov 13, 2023

Conversation

Xeonus
Copy link
Collaborator

@Xeonus Xeonus commented Nov 8, 2023

@Xeonus
BIP478: Enable 80mevETH/20FOLD Gauge [Ethereum]
6414b9a 
- enable mevETH-fold gauge on mainnet
- Tenderly-sim: https://dashboard.tenderly.co/public/safe/safe-apps/simulator/289ba8b5-6947-439e-aaca-5f676922e448
- core pool designation: 0x58b645fa247b60f2cb896991fd8956146c9fcb4a00020000000000000000061d
- rate provider review: balancer/frontend-v2#4538 -> PR for FE is in progress as there was a bug with upper-case additions
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

BIP validation results for file BIPs/2023-W45/BIP-478.json:
Commit: 6414b9a2c5aafd0be2d83518daf0c5af355eabcc

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

File name: BIPs/2023-W45/BIP-478.json
COMMIT: 6414b9a2c5aafd0be2d83518daf0c5af355eabcc
CHAIN(S): mainnet

+-----------------------+---------------------------------------------------------------------+-------------------------+--------------------------------------------+-------------------------------------------------------+------------------------------------------------+---------+------------+
| function              | pool_id_and_address                                                 | symbol_and_info         | gauge_address_and_info                     | tokens                                                | rate_providers                                 | bip     |   tx_index |
+=======================+=====================================================================+=========================+============================================+=======================================================+================================================+=========+============+
| GaugeAdderV4/addGauge | 0x58b645fa247b60f2cb896991fd8956146c9fcb4a00020000000000000000061d  | 80mevETH/20FOLD         | 0xC6C69b977329D93E34fDBD2c37Ab8e70b8decFCD | "mevETH(0x24Ae2dA0f361AA4BE46b48EB19C91e02c5e4f27E)", | "0xf518f2EbeA5df8Ca2B5E9C7996a2A25e8010014b",  | BIP-478 |          0 |
|                       | pool_address: 0x58B645FA247B60f2cB896991Fd8956146c9FCB4A            | fee: 0.3, a-factor: N/A |  Style: mainnet, cap: 100.0%               |   "FOLD(0xd084944d3c05CD115C09d072B9F44bA3E0E45921)"  |   "0x0000000000000000000000000000000000000000" |         |            |
+-----------------------+---------------------------------------------------------------------+-------------------------+--------------------------------------------+-------------------------------------------------------+------------------------------------------------+---------+------------+

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

BIP validation results for file BIPs/2023-W45/BIP-478.json:
Commit: 030558562fe7028ed0c6cae3cc73fc1b83ef93c9

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

File name: BIPs/2023-W45/BIP-478.json
COMMIT: 030558562fe7028ed0c6cae3cc73fc1b83ef93c9
CHAIN(S): mainnet

+-----------------------+---------------------------------------------------------------------+-------------------------+--------------------------------------------+-------------------------------------------------------+------------------------------------------------+---------+------------+
| function              | pool_id_and_address                                                 | symbol_and_info         | gauge_address_and_info                     | tokens                                                | rate_providers                                 | bip     |   tx_index |
+=======================+=====================================================================+=========================+============================================+=======================================================+================================================+=========+============+
| GaugeAdderV4/addGauge | 0x58b645fa247b60f2cb896991fd8956146c9fcb4a00020000000000000000061d  | 80mevETH/20FOLD         | 0xC6C69b977329D93E34fDBD2c37Ab8e70b8decFCD | "mevETH(0x24Ae2dA0f361AA4BE46b48EB19C91e02c5e4f27E)", | "0xf518f2EbeA5df8Ca2B5E9C7996a2A25e8010014b",  | BIP-478 |          0 |
|                       | pool_address: 0x58B645FA247B60f2cB896991Fd8956146c9FCB4A            | fee: 0.3, a-factor: N/A |  Style: mainnet, cap: 100.0%               |   "FOLD(0xd084944d3c05CD115C09d072B9F44bA3E0E45921)"  |   "0x0000000000000000000000000000000000000000" |         |            |
+-----------------------+---------------------------------------------------------------------+-------------------------+--------------------------------------------+-------------------------------------------------------+------------------------------------------------+---------+------------+

Tritium-VLK
Tritium-VLK previously approved these changes Nov 13, 2023
View reviewed changes
@Tritium-VLK Tritium-VLK merged commit 128d0e3 into main Nov 13, 2023
3 checks passed
@github-actions GitHub Actions
Copy link
Contributor

BIP validation results for file BIPs/2023-W45/BIP-478.json:
Commit: bc5a6de3b68f5d6964fba333f5d31459c7f671cd

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

@github-actions GitHub Actions
Copy link
Contributor

File name: BIPs/2023-W45/BIP-478.json
COMMIT: bc5a6de3b68f5d6964fba333f5d31459c7f671cd
CHAIN(S): mainnet

+-----------------------+---------------------------------------------------------------------+-------------------------+--------------------------------------------+-------------------------------------------------------+------------------------------------------------+---------+------------+
| function              | pool_id_and_address                                                 | symbol_and_info         | gauge_address_and_info                     | tokens                                                | rate_providers                                 | bip     |   tx_index |
+=======================+=====================================================================+=========================+============================================+=======================================================+================================================+=========+============+
| GaugeAdderV4/addGauge | 0x58b645fa247b60f2cb896991fd8956146c9fcb4a00020000000000000000061d  | 80mevETH/20FOLD         | 0xC6C69b977329D93E34fDBD2c37Ab8e70b8decFCD | "mevETH(0x24Ae2dA0f361AA4BE46b48EB19C91e02c5e4f27E)", | "0xf518f2EbeA5df8Ca2B5E9C7996a2A25e8010014b",  | BIP-478 |          0 |
|                       | pool_address: 0x58B645FA247B60f2cB896991Fd8956146c9FCB4A            | fee: 0.3, a-factor: N/A |  Style: mainnet, cap: 100.0%               |   "FOLD(0xd084944d3c05CD115C09d072B9F44bA3E0E45921)"  |   "0x0000000000000000000000000000000000000000" |         |            |
+-----------------------+---------------------------------------------------------------------+-------------------------+--------------------------------------------+-------------------------------------------------------+------------------------------------------------+---------+------------+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tritium-VLK Tritium-VLK Tritium-VLK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Xeonus @Tritium-VLK