Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIP-486: Update zkEVM Composable v5 permissions #622

Merged
merged 6 commits into from Nov 18, 2023
Merged

BIP-486: Update zkEVM Composable v5 permissions #622

merged 6 commits into from Nov 18, 2023

Conversation

zekraken-bot
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

BIP validation results for file BIPs/2023-W46/bip-xxx-add-roles-zkevm.json:
Commit: 1b3ac8084bd9e718500dae72350097a58a47da82

+-------------------------------+-----------------------------------------------------------------------------+
|           Validator           |                                    Result                                   |
+-------------------------------+-----------------------------------------------------------------------------+
|     validate_contains_msig    |                                      OK                                     |
| validate_msig_in_address_book |                                      OK                                     |
|    validate_chain_specified   |                                      OK                                     |
|     validate_file_has_bip     | No BIP number found in file path BIPs/2023-W46/bip-xxx-add-roles-zkevm.json |
|  validate_path_has_weekly_dir |                                      OK                                     |
+-------------------------------+-----------------------------------------------------------------------------+

BIP validation results for file BIPs/2023-W46/bip-xxx-revoke-roles-zkevm.json:
Commit: 1b3ac8084bd9e718500dae72350097a58a47da82

+-------------------------------+--------------------------------------------------------------------------------+
|           Validator           |                                     Result                                     |
+-------------------------------+--------------------------------------------------------------------------------+
|     validate_contains_msig    |                                       OK                                       |
| validate_msig_in_address_book |                                       OK                                       |
|    validate_chain_specified   |                                       OK                                       |
|     validate_file_has_bip     | No BIP number found in file path BIPs/2023-W46/bip-xxx-revoke-roles-zkevm.json |
|  validate_path_has_weekly_dir |                                       OK                                       |
+-------------------------------+--------------------------------------------------------------------------------+

@github-actions GitHub Actions
Copy link
Contributor

File name: BIPs/2023-W46/bip-xxx-add-roles-zkevm.json
COMMIT: 1b3ac8084bd9e718500dae72350097a58a47da82
CHAIN(S): zkevm

+-----------------------+--------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+-------+------------+
| function              | caller_name                                      | caller_address                             | fx_paths                                                                                                   | action_ids                                                         | bip   |   tx_index |
+=======================+==================================================+============================================+============================================================================================================+====================================================================+=======+============+
| Authorizer/grantRoles | multisigs/emergency                              | 0x79b131498355daa2cC740936fcb9A7dF76A86223 | 20230711-composable-stable-pool-v5/ComposableStablePoolFactory/disable()                                   | 0x64a2a630490e7632c2c8136b3761d329589d65bc8e9b6bb4864d79bc930d5e3c | N/A   |          0 |
|                       |                                                  |                                            | 20230711-composable-stable-pool-v5/ComposableStablePool/disableRecoveryMode()                              | 0x873caa0fd93d3c1661f94fc8bdbe1c379f7fcda27086da0c26ec1f38bead59c1 |       |            |
|                       |                                                  |                                            | 20230711-composable-stable-pool-v5/ComposableStablePool/pause()                                            | 0x2175568c6322118c9ae102adda930e3aee7b000bdf4cd0f0a0ee991c8c039d7e |       |            |
+-----------------------+--------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+-------+------------+
| Authorizer/grantRole  | 20221123-pool-recovery-helper/PoolRecoveryHelper | 0xf7D5DcE55E6D47852F054697BAB6A1B48A00ddbd | 20230711-composable-stable-pool-v5/ComposableStablePool/enableRecoveryMode()                               | 0x0060ad8f81979d2e64cb0d53e650dee47343f112c476effa7f1617731de77913 | N/A   |          1 |
+-----------------------+--------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+-------+------------+
| Authorizer/grantRoles | multisigs/feesManager                            | 0xB59Ab49CA8d064E645Bf2c546d9FE6d1d4147a09 | 20230711-composable-stable-pool-v5/ComposableStablePool/setSwapFeePercentage(uint256)                      | 0xbfd69d98e6966ce935b9eba83ae8f056ed06f6406b875e0cf728e3d9c2c39961 | N/A   |          2 |
|                       |                                                  |                                            | 20230711-composable-stable-pool-v5/ComposableStablePool/startAmplificationParameterUpdate(uint256,uint256) | 0x2cca85787a500e04397f218a9851b4521750e6dc26edfdb062bb37f2d79b8de7 |       |            |
|                       |                                                  |                                            | 20230711-composable-stable-pool-v5/ComposableStablePool/stopAmplificationParameterUpdate()                 | 0x5a443c2e20bbd9246c672bd23a142a1c540ad1190fd7e5148866e4356d60ab29 |       |            |
+-----------------------+--------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+-------+------------+

File name: BIPs/2023-W46/bip-xxx-revoke-roles-zkevm.json
COMMIT: 1b3ac8084bd9e718500dae72350097a58a47da82
CHAIN(S): zkevm

+------------------------+--------------------------------------------------+--------------------------------------------+------------+--------------------------------------------------------------------+-------+------------+
| function               | caller_name                                      | caller_address                             | fx_paths   | action_ids                                                         | bip   |   tx_index |
+========================+==================================================+============================================+============+====================================================================+=======+============+
| Authorizer/revokeRole  | 20221123-pool-recovery-helper/PoolRecoveryHelper | 0xf7D5DcE55E6D47852F054697BAB6A1B48A00ddbd |            | 0x6fa5acf6e6e303c2d281bf1af5f4d83642a125c5a3308cdf67e956bec276b69e | N/A   |          0 |
+------------------------+--------------------------------------------------+--------------------------------------------+------------+--------------------------------------------------------------------+-------+------------+
| Authorizer/revokeRoles | multisigs/emergency                              | 0x79b131498355daa2cC740936fcb9A7dF76A86223 |            | 0x0ebf042d38f8e1bb630c3010c686232d7334f90360a82eb23623fd01fbe8e656 | N/A   |          1 |
|                        |                                                  |                                            |            | 0xcfd45e344ead8485b80a5f9da66791663c8306984e9c6dc12eda2ee747cce604 |       |            |
|                        |                                                  |                                            |            | 0xa5d55e5978cb5ab0a8b23eed8889931ca33b54522edde10e348f4f96d35f0b35 |       |            |
+------------------------+--------------------------------------------------+--------------------------------------------+------------+--------------------------------------------------------------------+-------+------------+
| Authorizer/revokeRoles | multisigs/feesManager                            | 0xB59Ab49CA8d064E645Bf2c546d9FE6d1d4147a09 |            | 0x04dd8b85ae9bff95ec24f18269d23bd2d04784d5f5d8b35261545b82ed754a85 | N/A   |          2 |
|                        |                                                  |                                            |            | 0x1307ea331d8ab1feffafb967ddf20c66fd92ce496eda1de129a4608d4b40f313 |       |            |
|                        |                                                  |                                            |            | 0xbd408e756684e5ea83089ee33aa05ce9410b392967bffc71c11fb394026e7a09 |       |            |
+------------------------+--------------------------------------------------+--------------------------------------------+------------+--------------------------------------------------------------------+-------+------------+

@github-actions GitHub Actions
Copy link
Contributor

BIP validation results for file BIPs/2023-W46/bip-xxx-add-roles-zkevm.json:
Commit: cf8f728ccc6b5e04a7f86e9b05b74cb572a7fed6

+-------------------------------+-----------------------------------------------------------------------------+
|           Validator           |                                    Result                                   |
+-------------------------------+-----------------------------------------------------------------------------+
|     validate_contains_msig    |                                      OK                                     |
| validate_msig_in_address_book |                                      OK                                     |
|    validate_chain_specified   |                                      OK                                     |
|     validate_file_has_bip     | No BIP number found in file path BIPs/2023-W46/bip-xxx-add-roles-zkevm.json |
|  validate_path_has_weekly_dir |                                      OK                                     |
+-------------------------------+-----------------------------------------------------------------------------+

BIP validation results for file BIPs/2023-W46/bip-xxx-disable-old-factory.json:
Commit: cf8f728ccc6b5e04a7f86e9b05b74cb572a7fed6

+-------------------------------+---------------------------------------------------------------------------------+
|           Validator           |                                      Result                                     |
+-------------------------------+---------------------------------------------------------------------------------+
|     validate_contains_msig    |                                        OK                                       |
| validate_msig_in_address_book |                                        OK                                       |
|    validate_chain_specified   |                                        OK                                       |
|     validate_file_has_bip     | No BIP number found in file path BIPs/2023-W46/bip-xxx-disable-old-factory.json |
|  validate_path_has_weekly_dir |                                        OK                                       |
+-------------------------------+---------------------------------------------------------------------------------+

@github-actions GitHub Actions
Copy link
Contributor

File name: BIPs/2023-W46/bip-xxx-add-roles-zkevm.json
COMMIT: cf8f728ccc6b5e04a7f86e9b05b74cb572a7fed6
CHAIN(S): zkevm

+-----------------------+--------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+-------+------------+
| function              | caller_name                                      | caller_address                             | fx_paths                                                                                                   | action_ids                                                         | bip   |   tx_index |
+=======================+==================================================+============================================+============================================================================================================+====================================================================+=======+============+
| Authorizer/grantRoles | multisigs/emergency                              | 0x79b131498355daa2cC740936fcb9A7dF76A86223 | 20230711-composable-stable-pool-v5/ComposableStablePoolFactory/disable()                                   | 0x64a2a630490e7632c2c8136b3761d329589d65bc8e9b6bb4864d79bc930d5e3c | N/A   |          0 |
|                       |                                                  |                                            | 20230711-composable-stable-pool-v5/ComposableStablePool/disableRecoveryMode()                              | 0x873caa0fd93d3c1661f94fc8bdbe1c379f7fcda27086da0c26ec1f38bead59c1 |       |            |
|                       |                                                  |                                            | 20230711-composable-stable-pool-v5/ComposableStablePool/pause()                                            | 0x2175568c6322118c9ae102adda930e3aee7b000bdf4cd0f0a0ee991c8c039d7e |       |            |
+-----------------------+--------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+-------+------------+
| Authorizer/grantRole  | 20221123-pool-recovery-helper/PoolRecoveryHelper | 0xf7D5DcE55E6D47852F054697BAB6A1B48A00ddbd | 20230711-composable-stable-pool-v5/ComposableStablePool/enableRecoveryMode()                               | 0x0060ad8f81979d2e64cb0d53e650dee47343f112c476effa7f1617731de77913 | N/A   |          1 |
+-----------------------+--------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+-------+------------+
| Authorizer/grantRoles | multisigs/feesManager                            | 0xB59Ab49CA8d064E645Bf2c546d9FE6d1d4147a09 | 20230711-composable-stable-pool-v5/ComposableStablePool/setSwapFeePercentage(uint256)                      | 0xbfd69d98e6966ce935b9eba83ae8f056ed06f6406b875e0cf728e3d9c2c39961 | N/A   |          2 |
|                       |                                                  |                                            | 20230711-composable-stable-pool-v5/ComposableStablePool/startAmplificationParameterUpdate(uint256,uint256) | 0x2cca85787a500e04397f218a9851b4521750e6dc26edfdb062bb37f2d79b8de7 |       |            |
|                       |                                                  |                                            | 20230711-composable-stable-pool-v5/ComposableStablePool/stopAmplificationParameterUpdate()                 | 0x5a443c2e20bbd9246c672bd23a142a1c540ad1190fd7e5148866e4356d60ab29 |       |            |
+-----------------------+--------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+-------+------------+

File name: BIPs/2023-W46/bip-xxx-disable-old-factory.json
COMMIT: cf8f728ccc6b5e04a7f86e9b05b74cb572a7fed6
CHAIN(S): zkevm

+-----------------------+---------------+--------------------------------------------+------------+--------------------------------------------------------------------+-------+------------+
| function              | caller_name   | caller_address                             | fx_paths   | action_ids                                                         | bip   |   tx_index |
+=======================+===============+============================================+============+====================================================================+=======+============+
| Authorizer/grantRole  | multisigs/dao | 0x2f237e7643a3bF6Ef265dd6FCBcd26a7Cc38dbAa |            | 0x0ebf042d38f8e1bb630c3010c686232d7334f90360a82eb23623fd01fbe8e656 | N/A   |          0 |
+-----------------------+---------------+--------------------------------------------+------------+--------------------------------------------------------------------+-------+------------+
| Authorizer/revokeRole | multisigs/dao | 0x2f237e7643a3bF6Ef265dd6FCBcd26a7Cc38dbAa |            | 0x0ebf042d38f8e1bb630c3010c686232d7334f90360a82eb23623fd01fbe8e656 | N/A   |          2 |
+-----------------------+---------------+--------------------------------------------+------------+--------------------------------------------------------------------+-------+------------+

File name: BIPs/2023-W46/bip-xxx-disable-old-factory.json
COMMIT: cf8f728ccc6b5e04a7f86e9b05b74cb572a7fed6
CHAIN(S): 1101

+-----------+--------------------------------------------------------+---------+----------+--------------+------------+
| fx_name   | to                                                     |   value | inputs   | bip_number   | tx_index   |
+===========+========================================================+=========+==========+==============+============+
| disable   | 0x956CCab09898C0AF2aCa5e6C229c3aD4E93d9288 (Not Found) |       0 | "N/A"    | N/A          | N/A        |
+-----------+--------------------------------------------------------+---------+----------+--------------+------------+

@Xeonus Xeonus changed the title update zkevm permissions BIP-486: Update zkEVM Composable v5 permissions Nov 15, 2023
@github-actions GitHub Actions
Copy link
Contributor

BIP validation results for file BIPs/2023-W46/BIP-486-add-roles-zkevm.json:
Commit: 41e0c13582985f6609d9720627b57bd85505aaab

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

BIP validation results for file BIPs/2023-W46/BIP-486-disable-old-factory.json:
Commit: 41e0c13582985f6609d9720627b57bd85505aaab

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

@github-actions GitHub Actions
Copy link
Contributor

File name: BIPs/2023-W46/BIP-486-add-roles-zkevm.json
COMMIT: 41e0c13582985f6609d9720627b57bd85505aaab
CHAIN(S): zkevm

+-----------------------+--------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+------------+
| function              | caller_name                                      | caller_address                             | fx_paths                                                                                                   | action_ids                                                         | bip     |   tx_index |
+=======================+==================================================+============================================+============================================================================================================+====================================================================+=========+============+
| Authorizer/grantRoles | multisigs/emergency                              | 0x79b131498355daa2cC740936fcb9A7dF76A86223 | 20230711-composable-stable-pool-v5/ComposableStablePoolFactory/disable()                                   | 0x64a2a630490e7632c2c8136b3761d329589d65bc8e9b6bb4864d79bc930d5e3c | BIP-486 |          0 |
|                       |                                                  |                                            | 20230711-composable-stable-pool-v5/ComposableStablePool/disableRecoveryMode()                              | 0x873caa0fd93d3c1661f94fc8bdbe1c379f7fcda27086da0c26ec1f38bead59c1 |         |            |
|                       |                                                  |                                            | 20230711-composable-stable-pool-v5/ComposableStablePool/pause()                                            | 0x2175568c6322118c9ae102adda930e3aee7b000bdf4cd0f0a0ee991c8c039d7e |         |            |
+-----------------------+--------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+------------+
| Authorizer/grantRole  | 20221123-pool-recovery-helper/PoolRecoveryHelper | 0xf7D5DcE55E6D47852F054697BAB6A1B48A00ddbd | 20230711-composable-stable-pool-v5/ComposableStablePool/enableRecoveryMode()                               | 0x0060ad8f81979d2e64cb0d53e650dee47343f112c476effa7f1617731de77913 | BIP-486 |          1 |
+-----------------------+--------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+------------+
| Authorizer/grantRoles | multisigs/feesManager                            | 0xB59Ab49CA8d064E645Bf2c546d9FE6d1d4147a09 | 20230711-composable-stable-pool-v5/ComposableStablePool/setSwapFeePercentage(uint256)                      | 0xbfd69d98e6966ce935b9eba83ae8f056ed06f6406b875e0cf728e3d9c2c39961 | BIP-486 |          2 |
|                       |                                                  |                                            | 20230711-composable-stable-pool-v5/ComposableStablePool/startAmplificationParameterUpdate(uint256,uint256) | 0x2cca85787a500e04397f218a9851b4521750e6dc26edfdb062bb37f2d79b8de7 |         |            |
|                       |                                                  |                                            | 20230711-composable-stable-pool-v5/ComposableStablePool/stopAmplificationParameterUpdate()                 | 0x5a443c2e20bbd9246c672bd23a142a1c540ad1190fd7e5148866e4356d60ab29 |         |            |
+-----------------------+--------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+------------+

File name: BIPs/2023-W46/BIP-486-disable-old-factory.json
COMMIT: 41e0c13582985f6609d9720627b57bd85505aaab
CHAIN(S): zkevm

+-----------------------+---------------+--------------------------------------------+------------+--------------------------------------------------------------------+---------+------------+
| function              | caller_name   | caller_address                             | fx_paths   | action_ids                                                         | bip     |   tx_index |
+=======================+===============+============================================+============+====================================================================+=========+============+
| Authorizer/grantRole  | multisigs/dao | 0x2f237e7643a3bF6Ef265dd6FCBcd26a7Cc38dbAa |            | 0x0ebf042d38f8e1bb630c3010c686232d7334f90360a82eb23623fd01fbe8e656 | BIP-486 |          0 |
+-----------------------+---------------+--------------------------------------------+------------+--------------------------------------------------------------------+---------+------------+
| Authorizer/revokeRole | multisigs/dao | 0x2f237e7643a3bF6Ef265dd6FCBcd26a7Cc38dbAa |            | 0x0ebf042d38f8e1bb630c3010c686232d7334f90360a82eb23623fd01fbe8e656 | BIP-486 |          2 |
+-----------------------+---------------+--------------------------------------------+------------+--------------------------------------------------------------------+---------+------------+

File name: BIPs/2023-W46/BIP-486-disable-old-factory.json
COMMIT: 41e0c13582985f6609d9720627b57bd85505aaab
CHAIN(S): 1101

+-----------+--------------------------------------------------------+---------+----------+--------------+------------+
| fx_name   | to                                                     |   value | inputs   | bip_number   | tx_index   |
+===========+========================================================+=========+==========+==============+============+
| disable   | 0x956CCab09898C0AF2aCa5e6C229c3aD4E93d9288 (Not Found) |       0 | "N/A"    | BIP-486      | N/A        |
+-----------+--------------------------------------------------------+---------+----------+--------------+------------+

@Tritium-VLK Tritium-VLK merged commit b377aba into main Nov 18, 2023
@Tritium-VLK Tritium-VLK deleted the bip-xxx-zkevm-permissions branch November 27, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tritium-VLK Tritium-VLK Tritium-VLK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zekraken-bot @Tritium-VLK @Xeonus