Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP-496: Enable osETH/ETH Gauge [Ethereum] with 10% emission cap #668

Merged
merged 2 commits into from Dec 3, 2023

Conversation

Xeonus
Copy link
Collaborator

@Xeonus Xeonus commented Nov 30, 2023

Copy link
Contributor

BIP validation results for file BIPs/2023-W48/BIP-496.json:
Commit: 4a96a3cad8d037c30be84fba4b72395cee858569

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

Copy link
Contributor

File name: BIPs/2023-W48/BIP-496.json
COMMIT: 4a96a3cad8d037c30be84fba4b72395cee858569
CHAIN(S): mainnet

+-----------------------+---------------------------------------------------------------------+--------------------------+--------------------------------------------+-----------------------------------------------------------------+-------------------------------------------------+---------+------------+
| function              | pool_id_and_address                                                 | symbol_and_info          | gauge_address_and_info                     | tokens                                                          | rate_providers                                  | bip     |   tx_index |
+=======================+=====================================================================+==========================+============================================+=================================================================+=================================================+=========+============+
| GaugeAdderV4/addGauge | 0xdacf5fa19b1f720111609043ac67a9818262850c000000000000000000000635  | osETH/wETH-BPT           | 0xc592c33e51A764B94DB0702D8BAf4035eD577aED | "WETH(0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2)",             | "0x0000000000000000000000000000000000000000",   | BIP-496 |          0 |
|                       | pool_address: 0xDACf5Fa19b1f720111609043ac67A9818262850c            | fee: 0.01, a-factor: 200 |  Style: mainnet, cap: 10.0%                |   "osETH/wETH-BPT(0xDACf5Fa19b1f720111609043ac67A9818262850c)", |   "0x0000000000000000000000000000000000000000", |         |            |
|                       |                                                                     |                          |                                            |   "osETH(0xf1C9acDc66974dFB6dEcB12aA385b9cD01190E38)"           |   "0x8023518b2192FB5384DAdc596765B3dD1cdFe471"  |         |            |
+-----------------------+---------------------------------------------------------------------+--------------------------+--------------------------------------------+-----------------------------------------------------------------+-------------------------------------------------+---------+------------+

Copy link
Member

@gosuto-inzasheru gosuto-inzasheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • l0 gauge correctly refers to the lp
  • l0 gauge correctly capped at 10%
  • oseth rate provider has been reviewed
  • no core pool status as per bip

@gosuto-inzasheru gosuto-inzasheru merged commit 5891b61 into main Dec 3, 2023
@gosuto-inzasheru gosuto-inzasheru deleted the BIP-496-osETH-ETH-gauge-mainnet branch December 3, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants