Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIP-XXX: Enable SWEEP/USDC gauge [Arbitrum] #851

Closed
wants to merge 4 commits into from
Closed

BIP-XXX: Enable SWEEP/USDC gauge [Arbitrum] #851

wants to merge 4 commits into from

Conversation

Xeonus
Copy link
Collaborator

@Xeonus Xeonus commented Mar 21, 2024 •
edited

-enable sweep USDC gauge on Arbitrum with a 2% cap

@Xeonus
BIP-571: Enable SWEEP/USDC gauge [Arbitrum]
3fdfbde 
-enable sweep USDC gauge on Arbitrum with a 2% cap
@github-actions GitHub Actions
Copy link
Contributor

BIP validation results for file BIPs/2024-W13/BIP-571.json:
Commit: 3fdfbde63c38897501789d5fbeb7184c07bcc5fd

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

@github-actions GitHub Actions
Copy link
Contributor

FILENAME: BIPs/2024-W13/BIP-571.json
MULTISIG: multisigs/lm (mainnet:0xc38c5f97B34E175FFd35407fc91a937300E33860)
COMMIT: 3fdfbde63c38897501789d5fbeb7184c07bcc5fd
CHAIN(S): arbitrum
TENDERLY: SUCCESS

+-----------------------+---------------------------------------------------------------------+--------------------------+--------------------------------------------+----------------------------------------------------------------+-------------------------------------------------+---------+------------+
| function              | pool_id_and_address                                                 | symbol_and_info          | gauge_address_and_info                     | tokens                                                         | rate_providers                                  | bip     |   tx_index |
+=======================+=====================================================================+==========================+============================================+================================================================+=================================================+=========+============+
| GaugeAdderV4/addGauge | 0xef093ccfdd4d5a590b028463e0528049939889c90000000000000000000004cf  | SWEEP-USDC-BPT           | 0x1fD937692B82910a65d3A47AFBC5156AB192038F | "USDC(0xaf88d065e77c8cC2239327C5EDb3A432268e5831)",            | "0x0000000000000000000000000000000000000000",   | BIP-571 |          0 |
|                       | pool_address: 0xef093cCFdD4d5A590B028463E0528049939889C9            | fee: 0.01, a-factor: 500 |  Style: L0 sidechain, cap: 2.0%            |   "SWEEP(0xB88a5Ac00917a02d82c7cd6CEBd73E2852d43574)",         |   "0x0FbA85De62C85c3cB444ec828b42BbF0a9208318", |         |            |
|                       |                                                                     |                          |                                            |   "SWEEP-USDC-BPT(0xef093cCFdD4d5A590B028463E0528049939889C9)" |   "0x0000000000000000000000000000000000000000"  |         |            |
+-----------------------+---------------------------------------------------------------------+--------------------------+--------------------------------------------+----------------------------------------------------------------+-------------------------------------------------+---------+------------+

gosuto-inzasheru
gosuto-inzasheru requested changes Mar 21, 2024
View reviewed changes
Copy link
Member

@gosuto-inzasheru gosuto-inzasheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rate provider (0x0FbA85De62C85c3cB444ec828b42BbF0a9208318) != the one listed here: https://github.com/balancer/code-review/blob/main/rate-providers/sweepRateProvider.md

@Xeonus
Copy link
Collaborator Author

Xeonus commented Mar 21, 2024

Will hold off for now as rate provider is incorrect. Removing form snapshot and replacing specs once ready

@github-actions GitHub Actions
Copy link
Contributor

BIP validation results for file BIPs/2024-W13/BIP-571.json:
Commit: 213e05aab8eadcd418562281aee30f49ff0eafa2

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

@github-actions GitHub Actions
Copy link
Contributor

FILENAME: BIPs/2024-W13/BIP-571.json
MULTISIG: multisigs/lm (mainnet:0xc38c5f97B34E175FFd35407fc91a937300E33860)
COMMIT: 213e05aab8eadcd418562281aee30f49ff0eafa2
CHAIN(S): arbitrum
TENDERLY: SUCCESS

+-----------------------+---------------------------------------------------------------------+--------------------------+--------------------------------------------+----------------------------------------------------------------+-------------------------------------------------+---------+------------+
| function              | pool_id_and_address                                                 | symbol_and_info          | gauge_address_and_info                     | tokens                                                         | rate_providers                                  | bip     |   tx_index |
+=======================+=====================================================================+==========================+============================================+================================================================+=================================================+=========+============+
| GaugeAdderV4/addGauge | 0xef093ccfdd4d5a590b028463e0528049939889c90000000000000000000004cf  | SWEEP-USDC-BPT           | 0x1fD937692B82910a65d3A47AFBC5156AB192038F | "USDC(0xaf88d065e77c8cC2239327C5EDb3A432268e5831)",            | "0x0000000000000000000000000000000000000000",   | BIP-571 |          0 |
|                       | pool_address: 0xef093cCFdD4d5A590B028463E0528049939889C9            | fee: 0.01, a-factor: 500 |  Style: L0 sidechain, cap: 2.0%            |   "SWEEP(0xB88a5Ac00917a02d82c7cd6CEBd73E2852d43574)",         |   "0x0FbA85De62C85c3cB444ec828b42BbF0a9208318", |         |            |
|                       |                                                                     |                          |                                            |   "SWEEP-USDC-BPT(0xef093cCFdD4d5A590B028463E0528049939889C9)" |   "0x0000000000000000000000000000000000000000"  |         |            |
+-----------------------+---------------------------------------------------------------------+--------------------------+--------------------------------------------+----------------------------------------------------------------+-------------------------------------------------+---------+------------+

@Xeonus Xeonus changed the title BIP-571: Enable SWEEP/USDC gauge [Arbitrum] BIP-XXX: Enable SWEEP/USDC gauge [Arbitrum] Mar 21, 2024
@Tritium-VLK
Copy link
Member

Closing this. Can reopen if a BIP goes to snapshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gosuto-inzasheru gosuto-inzasheru gosuto-inzasheru requested changes

Assignees
No one assigned
Labels
Do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Xeonus @Tritium-VLK @gosuto-inzasheru